From: Johan Hedberg <johan.hedberg@gmail.com>
To: Zhu Yanhai <yanhai.zhu@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Don't pass down NULL path to dbus if no modem.
Date: Mon, 11 Jan 2010 15:53:25 +0200 [thread overview]
Message-ID: <20100111135325.GA10569@jh-x301> (raw)
In-Reply-To: <1263195386-15072-1-git-send-email-yanhai.zhu@linux.intel.com>
Hi,
On Mon, Jan 11, 2010, Zhu Yanhai wrote:
> index 2778cfc..2970e43 100644
> --- a/audio/telephony-ofono.c
> +++ b/audio/telephony-ofono.c
> @@ -579,6 +579,11 @@ static void list_modem_reply(DBusPendingCall *call, void *user_data)
> modem_obj_path);
> dbus_message_iter_next(&sub);
> }
> + if (modem_obj_path == NULL)
> + {
> + debug("no modem found.\n");
> + goto done;
> + }
Functionally the patch seems fine, but could you fix a few coding style
issues please:
* empty line before the if-statement
* opening { on the same line as the if statement
* no \n in the debug statement (that gets added automatically).
* Remove whitespace from the end of the debug line (right now you have
a tab after the semicolon)
Johan
next prev parent reply other threads:[~2010-01-11 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 7:36 [PATCH] Don't pass down NULL path to dbus if no modem Zhu Yanhai
2010-01-11 13:53 ` Johan Hedberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-12 6:15 Zhu Yanhai
2010-01-12 6:25 ` Zhu Yanhai
2010-01-13 6:28 ` Johan Hedberg
2010-01-13 6:52 ` Zhu Yanhai
2010-01-13 7:35 ` Johan Hedberg
2010-01-13 7:46 ` Zhu Yanhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100111135325.GA10569@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=yanhai.zhu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).