linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Maas <frank.maas@cheiron-it.nl>
To: linux-bluetooth@vger.kernel.org
Subject: Re: Problem with 'inquiry_cache' in sysfs
Date: Sun, 7 Feb 2010 14:30:15 +0100	[thread overview]
Message-ID: <20100207133015.GD28037@xs4all.nl> (raw)
In-Reply-To: <1265399409.31341.241.camel@localhost.localdomain>

Hello Marcel,

> > I am currently developing a system that relies heavily on the Linux 
> > bluetooth stack. That system uses the sysfs interface to the kernel 
> > module and more specifically the entry 'inquiry_cache' of the device 
> > "directory".
> 
> that file should have been moved to debugfs, but we haven't done that
> yet. It really doesn't belong in sysfs at all. And should not be treated
> as an API.

If I can be blunt: please remove it asap. It is very simple to make a 
system crash for a simple user while this is part of the distribution. 
And perhaps even worse options exists.

I'd like to point out that the functionality it offers is of use. As far 
as I have seen the 'hcitool' offers an inquiry functionality, but that 
starts an inquiry itself. The 'benefit' of the current inquire_cache 
file is that one can use it without having to wait for an inquiry to 
finish and while knowing that the cache is pretty recent. Perhaps 
hcitool could be extended with an option for 'inq' that suppresses the 
inquiry itself?

Kind regards,
Frank


  reply	other threads:[~2010-02-07 13:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-04 22:05 Problem with 'inquiry_cache' in sysfs Frank Maas
2010-02-05 19:50 ` Marcel Holtmann
2010-02-07 13:30   ` Frank Maas [this message]
2010-02-08  7:48     ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100207133015.GD28037@xs4all.nl \
    --to=frank.maas@cheiron-it.nl \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).