From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Daniel Örstadius" <daniel.orstadius@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix double free on AVDTP Abort response
Date: Fri, 19 Feb 2010 14:32:58 -0300 [thread overview]
Message-ID: <20100219173257.GA12855@jh-x301> (raw)
In-Reply-To: <eb7933e21002190820x7b2b0ea3v3f48ce96a5d11a1e@mail.gmail.com>
Hi Daniel,
On Fri, Feb 19, 2010, Daniel Örstadius wrote:
> + if (session->req == AVDTP_ABORT) {
> + /* Avoid freeing the Abort request here */
> + debug("handle_unanswered_req: Abort req, returning");
> + session->req->stream = NULL;
> + return;
> + }
Please try to at least do a compile check before you submit patches.
This one gives the following error:
audio/avdtp.c: In function ‘handle_unanswered_req’:
audio/avdtp.c:908: error: comparison between pointer and integer
What you probably want is session->req->signal_id == AVDTP_ABORT.
Johan
next prev parent reply other threads:[~2010-02-19 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 16:20 [PATCH] Fix double free on AVDTP Abort response Daniel Örstadius
2010-02-19 17:32 ` Johan Hedberg [this message]
2010-02-21 12:54 ` Daniel Örstadius
2010-02-21 13:04 ` Marcel Holtmann
2010-02-21 13:46 ` Johan Hedberg
2010-02-21 17:53 ` Luiz Augusto von Dentz
2010-02-23 14:04 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219173257.GA12855@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=daniel.orstadius@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).