From: Johan Hedberg <johan.hedberg@gmail.com>
To: Liang Bao <tim.bao@gmail.com>, marcel@holtmann.org
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Allow disable park state in main.conf
Date: Fri, 26 Feb 2010 11:38:29 -0300 [thread overview]
Message-ID: <20100226143829.GA17869@jh-x301> (raw)
In-Reply-To: <6aeb672b1002260532v6e209d7dr8370003463334b3@mail.gmail.com>
Hi,
On Fri, Feb 26, 2010, Liang Bao wrote:
> Currently BlueZ is hard-coding the default link policy to include
> hold mode, role switch, sniff mode and park state. However, some
> device will have problem to maintain the connection or setup SCO
> if they are in park state. Making the park state configurable in
> main.conf improves flexibility so it can be disabled when needed.
>
> Signed-off-by: Tim Bao <tim.bao@gmail.com>
> ---
> src/main.c | 13 +++++++++----
> src/main.conf | 5 +++++
> 2 files changed, 14 insertions(+), 4 deletions(-)
In principle the patch looks ok to me, however we might want to discuss
a little bit about the naming of the parameter in the config file and
its possible values. E.g. would it make sense to be able to define the
link policy more flexibly than just toggling park mode on and off.
Marcel, do you have any thoughts on this?
Johan
next prev parent reply other threads:[~2010-02-26 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 13:32 [PATCH] Allow disable park state in main.conf Liang Bao
2010-02-26 14:38 ` Johan Hedberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-26 15:11 Bao Liang
2010-03-05 12:23 ` Liang Bao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226143829.GA17869@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=tim.bao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox