From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 8 Mar 2010 15:15:59 +0300 From: Dan Carpenter To: Marcel Holtmann Cc: Bing Zhao , Rahul Tank , Amitkumar Karwar , linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] bluetooth: storing negative values as unsigned char Message-ID: <20100308121559.GG6469@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-ID: This is mostly cleanup. There is only one caller and it just checks for non-zero return values. Still "ret" should be int because we want to return -EINVAL on errors. Signed-off-by: Dan Carpenter diff --git a/drivers/bluetooth/btmrvl_main.c b/drivers/bluetooth/btmrvl_main.c index 53a43ad..49ec89c 100644 --- a/drivers/bluetooth/btmrvl_main.c +++ b/drivers/bluetooth/btmrvl_main.c @@ -66,7 +66,7 @@ int btmrvl_process_event(struct btmrvl_private *priv, struct sk_buff *skb) { struct btmrvl_adapter *adapter = priv->adapter; struct btmrvl_event *event; - u8 ret = 0; + int ret = 0; event = (struct btmrvl_event *) skb->data; if (event->ec != 0xff) {