From: Johan Hedberg <johan.hedberg@gmail.com>
To: Forrest Zhao <forrest.zhao@intel.com>
Cc: linux-bluetooth@vger.kernel.org, forrest.zhao@gmail.com
Subject: Re: [PATCH] Set voice_call.watch in correct way
Date: Thu, 25 Mar 2010 12:12:23 +0200 [thread overview]
Message-ID: <20100325101223.GA25089@jh-x301> (raw)
In-Reply-To: <1269534610-1138-1-git-send-email-forrest.zhao@intel.com>
Hi Forrest,
On Thu, Mar 25, 2010, Forrest Zhao wrote:
> It was set wrongly to device_watch.
> ---
> audio/telephony-ofono.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/telephony-ofono.c b/audio/telephony-ofono.c
> index c19e6ee..45c3905 100644
> --- a/audio/telephony-ofono.c
> +++ b/audio/telephony-ofono.c
> @@ -850,7 +850,7 @@ static gboolean handle_vcmanager_property_changed(DBusConnection *conn,
> vc_new = g_new0(struct voice_call, 1);
> vc_new->obj_path = g_strdup(vc_obj_path);
> calls = g_slist_append(calls, vc_new);
> - device_watch = g_dbus_add_signal_watch(connection,
> + vc_new->watch = g_dbus_add_signal_watch(connection,
> NULL, vc_obj_path,
> OFONO_VC_INTERFACE,
> "PropertyChanged",
Pushed upstream. Thanks.
Johan
prev parent reply other threads:[~2010-03-25 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 16:30 [PATCH] Set voice_call.watch in correct way Forrest Zhao
2010-03-25 10:12 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325101223.GA25089@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=forrest.zhao@gmail.com \
--cc=forrest.zhao@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).