linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Francisco Alecrim <francisco.alecrim@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH v2 2/2] Emit Adapter.PropertyChanged when UUIDs change
Date: Mon, 29 Mar 2010 10:45:39 +0300	[thread overview]
Message-ID: <20100329074539.GA20839@jh-x301> (raw)
In-Reply-To: <1269644076-10544-2-git-send-email-francisco.alecrim@openbossa.org>

Hi,

On Fri, Mar 26, 2010, Francisco Alecrim wrote:
> Emitting Adapter.PropertyChanged signal when UUIDs change. D-Bus message
> to inform that adapter properties changed.
> ---
>  src/adapter.c       |   75 ++++++++++++++++++++++++++++++++++++++++++++------
>  src/adapter.h       |    1 +
>  src/sdpd-database.c |    3 ++
>  3 files changed, 70 insertions(+), 9 deletions(-)

Thanks for the patches. In principle they look good, but I haven't
applied them yet due to one thing that looks a bit strange: both the SDP
server record UUID (0x1000) as well as the public browse group UUID
(0x1001) always show up in the UUIDs list. I wonder if there'd be any
clean way to avoid getting them into the list. Marcel, do you have any
idea about this or is it even a problem that these UUIDs are always in
the list?

Johan

  reply	other threads:[~2010-03-29  7:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26 22:54 [PATCH v2 1/2] Report local services(UUIDs) through DBus Francisco Alecrim
2010-03-26 22:54 ` [PATCH v2 2/2] Emit Adapter.PropertyChanged when UUIDs change Francisco Alecrim
2010-03-29  7:45   ` Johan Hedberg [this message]
2010-03-29  8:29     ` Marcel Holtmann
2010-03-29 18:48       ` Luiz Augusto von Dentz
2010-03-29 21:52         ` Johan Hedberg
2010-03-29 22:12           ` Francisco Alecrim
2010-03-29 22:56             ` Johan Hedberg
2010-03-30  1:21               ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100329074539.GA20839@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=francisco.alecrim@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).