From: Johan Hedberg <johan.hedberg@gmail.com>
To: Francisco Alecrim <francisco.alecrim@openbossa.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Emit Adapter.PropertyChanged when UUIDs change
Date: Tue, 30 Mar 2010 01:56:43 +0300 [thread overview]
Message-ID: <20100329225643.GA5460@jh-x301> (raw)
In-Reply-To: <4BB125E8.1090200@openbossa.org>
Hi Alecrim,
On Mon, Mar 29, 2010, Francisco Alecrim wrote:
> >> IMO, it should be the same list as we export in extended inquiry
> >> response, so perhaps we could use the data from
> >> create_ext_inquiry_response which already filter those away. Perhaps
> >> some refactoring could also be done since this code seems to be called
> >> multiple times in case of new services because it also changes class
> >> which then triggers create_ext_inquiry_response again.
>
> I'm not so sure about it but create_ext_inquiry_response list all
> services to any adapters. Shouldn't it list just services per
> adapter(access_db)?
It should be per-adapter (or records registered to BDADDR_ANY) since EIR
is also per-adapter, so looks like a possible bug in the current
implementation.
Btw, another restriction to note with the current EIR UUID list
implementation is that it only supports 16-bit UUIDs. The EIR format
itself would support also 32 and 128 bit formats but probably for
simplicity these have been left out. The Adapter UUIDs list should
however contain all UUIDs (with the exceptions that we already
discussed).
Johan
next prev parent reply other threads:[~2010-03-29 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 22:54 [PATCH v2 1/2] Report local services(UUIDs) through DBus Francisco Alecrim
2010-03-26 22:54 ` [PATCH v2 2/2] Emit Adapter.PropertyChanged when UUIDs change Francisco Alecrim
2010-03-29 7:45 ` Johan Hedberg
2010-03-29 8:29 ` Marcel Holtmann
2010-03-29 18:48 ` Luiz Augusto von Dentz
2010-03-29 21:52 ` Johan Hedberg
2010-03-29 22:12 ` Francisco Alecrim
2010-03-29 22:56 ` Johan Hedberg [this message]
2010-03-30 1:21 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329225643.GA5460@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=francisco.alecrim@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).