From: Johan Hedberg <johan.hedberg@gmail.com>
To: Francisco Alecrim <francisco.alecrim@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Report local services(UUIDs) through DBus
Date: Wed, 7 Apr 2010 18:30:00 +0300 [thread overview]
Message-ID: <20100407153000.GA27553@jh-x301> (raw)
In-Reply-To: <1270652663-23107-2-git-send-email-francisco.alecrim@openbossa.org>
Hi Alecrim,
A few more minor correction suggestions:
On Wed, Apr 07, 2010, Francisco Alecrim wrote:
> + emit_array_property_changed(connection, adapter->path,
> + ADAPTER_INTERFACE, "UUIDs",
> + DBUS_TYPE_STRING, &uuids);
The general rule for continuation line indenting is: indent as much as
possible as long as the total length doesn't go beyond 80. It looks like
these two lines could be indented a bit more. There are a few other
similar places too but I think you should be able to find them by
yourself.
> + for (i = 0; uuids[i]; i++)
> + g_free(uuids[i]);
> + g_free(uuids);
These three lines could be replaced simply with g_strfreev(uuids);
> + for (i = 0; uuids[i]; i++)
> + g_free(uuids[i]);
> + g_free(uuids);
And same here.
Johan
next prev parent reply other threads:[~2010-04-07 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 15:04 [PATCH v2 0/2] Services through DBus and correct EIR Francisco Alecrim
2010-04-07 15:04 ` [PATCH v2 1/2] Report local services(UUIDs) through DBus Francisco Alecrim
2010-04-07 15:04 ` [PATCH v2 2/2] Correct UUIDs list to EIR Francisco Alecrim
2010-04-07 15:30 ` Johan Hedberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-26 22:54 [PATCH v2 1/2] Report local services(UUIDs) through DBus Francisco Alecrim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407153000.GA27553@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=francisco.alecrim@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).