From: David Miller <davem@davemloft.net>
To: gustavo@padovan.org
Cc: error27@gmail.com, marcel@holtmann.org,
andrei.emeltchenko@nokia.com, linux-bluetooth@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] bluetooth: handle l2cap_create_connless_pdu() errors
Date: Mon, 26 Apr 2010 11:12:59 -0700 (PDT) [thread overview]
Message-ID: <20100426.111259.112594696.davem@davemloft.net> (raw)
In-Reply-To: <20100426150919.GA12813@vigoh>
From: "Gustavo F. Padovan" <gustavo@padovan.org>
Date: Mon, 26 Apr 2010 12:09:19 -0300
> Hi Dan,
>
> * Dan Carpenter <error27@gmail.com> [2010-04-26 13:36:27 +0200]:
>
>> l2cap_create_connless_pdu() can sometimes return ERR_PTR(-ENOMEM) or
>> ERR_PTR(-EFAULT).
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>> ---
>> In v2 I wrote the patch on top of Gustavo Padovon's devel tree
This is the kind of bug that could cause a crash if the path actually
executes.
Therefore it tires me that that submitter was told to regenerate this
patch against some devel tree that is -next bound, when in fact this
is the kind of fix that warrants inclusion right now into net-2.6
Marcel, please do whatever magic you need to so I can get this into
Linus's tree as I did the rest of the ERR_PTR() fixes from Dan already.
No reason to treat Bluetooth special and defer these fixes to -next.
Thanks.
next prev parent reply other threads:[~2010-04-26 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:52 [patch] bluetooth: handle l2cap_create_connless_pdu() errors Dan Carpenter
2010-04-22 12:33 ` Gustavo F. Padovan
2010-04-26 11:36 ` [patch v2] " Dan Carpenter
2010-04-26 15:09 ` Gustavo F. Padovan
2010-04-26 18:12 ` David Miller [this message]
2010-04-26 18:27 ` Gustavo F. Padovan
2010-04-27 2:05 ` Marcel Holtmann
2010-04-28 0:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100426.111259.112594696.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrei.emeltchenko@nokia.com \
--cc=error27@gmail.com \
--cc=gustavo@padovan.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).