From: Johan Hedberg <johan.hedberg@gmail.com>
To: Santiago Carot Nemesio <scarot@libresoft.es>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] SDP memory checks
Date: Tue, 27 Apr 2010 13:15:32 +0300 [thread overview]
Message-ID: <20100427101532.GB6555@jh-x301> (raw)
In-Reply-To: <1272353139.2157.8.camel@mosquito>
Hi,
On Tue, Apr 27, 2010, Santiago Carot Nemesio wrote:
> This patch add some memory checks after malloc is called. Also some
> blank spaces at the end of the lines are removed. I observed that
> sometimes functions returns NULL or 0 without any convention. I set
> all to NULL to formalice the source code.
Thanks for the patch. It looks good, but could you split it into two
parts: one patch for the coding style fixes (whitespace, changing 0 to
NULL, etc) and another one to fix the missing malloc error checks. Also
use "git format-patch" to create the patches so that they can be easily
applied using "git am".
Johan
prev parent reply other threads:[~2010-04-27 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 7:25 [PATCH] SDP memory checks Santiago Carot Nemesio
2010-04-27 10:15 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427101532.GB6555@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=scarot@libresoft.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox