Re: [PATCH] patch to request new firmware for AR3011 Chip

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Tue, Apr 27, 2010 at 01:28:42AM -0700, Suraj Sumangala wrote:
> 
> Signed-off-by: Vikram Kandukuri <vkandukuri@atheros.com>
> ---
>  drivers/bluetooth/ath3k.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index 128cae4..7bda549 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -122,9 +122,12 @@ static int ath3k_probe(struct usb_interface *intf,
>  
>  	data->udev = udev;
>  
> -	if (request_firmware(&firmware, "ath3k-1.fw", &udev->dev) < 0) {
> -		kfree(data);
> -		return -EIO;
> +	if (request_firmware(&firmware, "ath3k-2.fw", &udev->dev) < 0) {
> +		BT_DBG("requesting old firmware");
> +		if (request_firmware(&firmware, "ath3k-1.fw", &udev->dev) < 0) {
> +			kfree(data);
> +			return -EIO;
> +		}
>  	}
>  
>  	size = max_t(uint, firmware->size, 4096);
> 

Looks OK but your subject should be something like:

[PATCH] ath3k: add support for new firmware

And your commit log is empty, other than your subject, please
be a little more descriptive. Describe what are the shiny new bells
and whistles added onto the new firmware. The more description
you can provide, the better.

  Luis