From: Johan Hedberg <johan.hedberg@gmail.com>
To: "José Antonio Santos Cadenas" <jcaden@libresoft.es>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bug in sdp_set_supp_features solved
Date: Wed, 28 Apr 2010 22:51:27 +0300 [thread overview]
Message-ID: <20100428195127.GA24058@jh-x301> (raw)
In-Reply-To: <201004281208.35923.jcaden@libresoft.es>
Hi,
On Wed, Apr 28, 2010, José Antonio Santos Cadenas wrote:
> From 567522ed4ac5912d967fef3017bf905591b5c24e Mon Sep 17 00:00:00 2001
> From: Jose Antonio Santos Cadenas <santoscadenas@gmail.com>
> Date: Wed, 28 Apr 2010 12:02:31 +0200
> Subject: [PATCH] Bug in sdp_set_supp_features solved
>
> When the data is a string or a sequence, it is not ok to dereference
> data->val because it is already a pointer.
> ---
> lib/sdp.c | 33 +++++++++++++++++++++++++++++++--
> 1 files changed, 31 insertions(+), 2 deletions(-)
The patch has been pushed upstream with some minor changes. I had to
edit the commit message again (try "git am" on your mail yourself and
you'll see the difference to what got pushed upstream) and I named the
new variable lengths instead of sizes since the function it gets passed
to is called sdp_seq_alloc_with_length.
Since there's no code in the bluez tree that calls this
sdp_set_supp_features function do you perhaps have some simple code
snippet/use case that the fixed functionality could be tested with?
Johan
next prev parent reply other threads:[~2010-04-28 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 10:08 [PATCH] Bug in sdp_set_supp_features solved José Antonio Santos Cadenas
2010-04-28 10:11 ` José Antonio Santos Cadenas
2010-04-28 19:51 ` Johan Hedberg [this message]
2010-04-28 22:28 ` José Antonio Santos Cadenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428195127.GA24058@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=jcaden@libresoft.es \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).