From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Elvis Pfützenreuter" <epx@signove.com>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH] Changed MDP profile name and macros to HDP
Date: Thu, 6 May 2010 23:51:20 +0300 [thread overview]
Message-ID: <20100506205120.GA10204@jh-x301> (raw)
In-Reply-To: <1273178318-10490-1-git-send-email-epx@signove.com>
Hi Elvis,
On Thu, May 06, 2010, Elvis Pfützenreuter wrote:
> --- a/lib/sdp.h
> +++ b/lib/sdp.h
> @@ -140,9 +140,9 @@ extern "C" {
> #define VIDEO_SOURCE_SVCLASS_ID 0x1303
> #define VIDEO_SINK_SVCLASS_ID 0x1304
> #define VIDEO_DISTRIBUTION_SVCLASS_ID 0x1305
> -#define MDP_SVCLASS_ID 0x1400
> -#define MDP_SOURCE_SVCLASS_ID 0x1401
> -#define MDP_SINK_SVCLASS_ID 0x1402
> +#define HDP_SVCLASS_ID 0x1400
> +#define HDP_SOURCE_SVCLASS_ID 0x1401
> +#define HDP_SINK_SVCLASS_ID 0x1402
> #define APPLE_AGENT_SVCLASS_ID 0x2112
>
> /*
> @@ -212,9 +212,9 @@ extern "C" {
> #define VIDEO_SOURCE_PROFILE_ID VIDEO_SOURCE_SVCLASS_ID
> #define VIDEO_SINK_PROFILE_ID VIDEO_SINK_SVCLASS_ID
> #define VIDEO_DISTRIBUTION_PROFILE_ID VIDEO_DISTRIBUTION_SVCLASS_ID
> -#define MDP_PROFILE_ID MDP_SVCLASS_ID
> -#define MDP_SOURCE_PROFILE_ID MDP_SROUCE_SVCLASS_ID
> -#define MDP_SINK_PROFILE_ID MDP_SINK_SVCLASS_ID
> +#define HDP_PROFILE_ID HDP_SVCLASS_ID
> +#define HDP_SOURCE_PROFILE_ID HDP_SROUCE_SVCLASS_ID
> +#define HDP_SINK_PROFILE_ID HDP_SINK_SVCLASS_ID
> #define APPLE_AGENT_PROFILE_ID APPLE_AGENT_SVCLASS_ID
Thanks for the patch!
Since this essentially breaks the library API we should probably
consider leaving the MDP defines there as "synonyms" and then just add
the HDP defines with the same values. However I'll leave it for Marcel
to decide how important this non-breakage is.
Btw, the commit message summary line should be in the form "Change ..."
or "Fix ..." (not "Changed ...") to be consistent with the rest of the
commit history.
Johan
next prev parent reply other threads:[~2010-05-06 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 20:38 [PATCH] Changed MDP profile name and macros to HDP Elvis Pfützenreuter
2010-05-06 20:51 ` Johan Hedberg [this message]
2010-05-06 20:51 ` Nathan Holstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506205120.GA10204@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=epx@signove.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).