From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jose Antonio Santos Cadenas <santoscadenas@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH 6/6] Change end of line from DOS to UNIX
Date: Fri, 7 May 2010 01:56:33 +0300 [thread overview]
Message-ID: <20100506225633.GA15821@jh-x301> (raw)
In-Reply-To: <1273184832-8265-6-git-send-email-santoscadenas@gmail.com>
Hi,
On Fri, May 07, 2010, Jose Antonio Santos Cadenas wrote:
> Files tools/ubcsp.c and tools/ubcsp.h had DOS end of line now they
> are changed to UNIX end of line
> ---
> tools/ubcsp.c | 2360 ++++++++++++++++++++++++++++----------------------------
> tools/ubcsp.h | 414 +++++-----
> 2 files changed, 1387 insertions(+), 1387 deletions(-)
Thanks for these cleanup patches. I've pushed the first five upstream
but am a little bit hesitant about this sixth one since it essentially
replaces every line in the existing file and I'm not sure if it's worth
having that obfuscating the commit history (e.g. git blame wouldn't be
useful anymore). Marcel, do you have any opinion about having a patch
like that in the tree?
Johan
next prev parent reply other threads:[~2010-05-06 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 22:27 [PATCH 1/6] Removed extra spaces at end of line in compat dir Jose Antonio Santos Cadenas
2010-05-06 22:27 ` [PATCH 2/6] Remove extra spaces at end of line in lib dir Jose Antonio Santos Cadenas
2010-05-06 22:27 ` [PATCH 3/6] Remove extra spaces from sdpd-request.c Jose Antonio Santos Cadenas
2010-05-06 22:27 ` [PATCH 4/6] Remove extra spaces in test dir Jose Antonio Santos Cadenas
2010-05-06 22:27 ` [PATCH 5/6] Remove extra spaces from tools dir Jose Antonio Santos Cadenas
2010-05-06 22:27 ` [PATCH 6/6] Change end of line from DOS to UNIX Jose Antonio Santos Cadenas
2010-05-06 22:56 ` Johan Hedberg [this message]
2010-05-07 8:15 ` José Antonio Santos Cadenas
2010-05-06 22:29 ` [PATCH 1/6] Removed extra spaces at end of line in compat dir José Antonio Santos Cadenas
2010-05-06 22:30 ` [PATCH 1/6] Remove " Jose Antonio Santos Cadenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506225633.GA15821@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=santoscadenas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).