From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: Julia Lawall <julia@diku.dk>
Cc: Marcel Holtmann <marcel@holtmann.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 9/20] drivers/bluetooth: Use kzalloc
Date: Thu, 13 May 2010 17:23:10 -0300 [thread overview]
Message-ID: <20100513202310.GA11617@vigoh> (raw)
In-Reply-To: <Pine.LNX.4.64.1005132201470.6282@ask.diku.dk>
* Julia Lawall <julia@diku.dk> [2010-05-13 22:02:03 +0200]:
> From: Julia Lawall <julia@diku.dk>
>
> Use kzalloc rather than the combination of kmalloc and memset.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,size,flags;
> statement S;
> @@
>
> -x = kmalloc(size,flags);
> +x = kzalloc(size,flags);
> if (x == NULL) S
> -memset(x, 0, size);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff -u -p a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
> --- a/drivers/bluetooth/btmrvl_sdio.c
> +++ b/drivers/bluetooth/btmrvl_sdio.c
> @@ -216,7 +216,7 @@ static int btmrvl_sdio_download_helper(s
>
> tmphlprbufsz = ALIGN_SZ(BTM_UPLD_SIZE, BTSDIO_DMA_ALIGN);
>
> - tmphlprbuf = kmalloc(tmphlprbufsz, GFP_KERNEL);
> + tmphlprbuf = kzalloc(tmphlprbufsz, GFP_KERNEL);
> if (!tmphlprbuf) {
> BT_ERR("Unable to allocate buffer for helper."
> " Terminating download");
> @@ -224,8 +224,6 @@ static int btmrvl_sdio_download_helper(s
> goto done;
> }
>
> - memset(tmphlprbuf, 0, tmphlprbufsz);
> -
> helperbuf = (u8 *) ALIGN_ADDR(tmphlprbuf, BTSDIO_DMA_ALIGN);
>
> /* Perform helper data transfer */
> @@ -318,7 +316,7 @@ static int btmrvl_sdio_download_fw_w_hel
> BT_DBG("Downloading FW image (%d bytes)", firmwarelen);
>
> tmpfwbufsz = ALIGN_SZ(BTM_UPLD_SIZE, BTSDIO_DMA_ALIGN);
> - tmpfwbuf = kmalloc(tmpfwbufsz, GFP_KERNEL);
> + tmpfwbuf = kzalloc(tmpfwbufsz, GFP_KERNEL);
> if (!tmpfwbuf) {
> BT_ERR("Unable to allocate buffer for firmware."
> " Terminating download");
> @@ -326,8 +324,6 @@ static int btmrvl_sdio_download_fw_w_hel
> goto done;
> }
>
> - memset(tmpfwbuf, 0, tmpfwbufsz);
> -
> /* Ensure aligned firmware buffer */
> fwbuf = (u8 *) ALIGN_ADDR(tmpfwbuf, BTSDIO_DMA_ALIGN);
>
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://padovan.org
next prev parent reply other threads:[~2010-05-13 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 20:02 [PATCH 9/20] drivers/bluetooth: Use kzalloc Julia Lawall
2010-05-13 20:23 ` Gustavo F. Padovan [this message]
2010-07-08 22:01 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513202310.GA11617@vigoh \
--to=gustavo@padovan.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).