* [PATCH 20/37] drivers/bluetooth: Use kmemdup
@ 2010-05-15 21:19 Julia Lawall
2010-05-16 4:53 ` Gustavo F. Padovan
2010-07-08 21:57 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2010-05-15 21:19 UTC (permalink / raw)
To: Marcel Holtmann, linux-bluetooth, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Use kmemdup when some other buffer is immediately copied into the
allocated region.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/bluetooth/bcm203x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -u -p a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c
--- a/drivers/bluetooth/bcm203x.c
+++ b/drivers/bluetooth/bcm203x.c
@@ -224,7 +224,7 @@ static int bcm203x_probe(struct usb_inte
BT_DBG("firmware data %p size %zu", firmware->data, firmware->size);
- data->fw_data = kmalloc(firmware->size, GFP_KERNEL);
+ data->fw_data = kmemdup(firmware->data, firmware->size, GFP_KERNEL);
if (!data->fw_data) {
BT_ERR("Can't allocate memory for firmware image");
release_firmware(firmware);
@@ -234,7 +234,6 @@ static int bcm203x_probe(struct usb_inte
return -ENOMEM;
}
- memcpy(data->fw_data, firmware->data, firmware->size);
data->fw_size = firmware->size;
data->fw_sent = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 20/37] drivers/bluetooth: Use kmemdup
2010-05-15 21:19 [PATCH 20/37] drivers/bluetooth: Use kmemdup Julia Lawall
@ 2010-05-16 4:53 ` Gustavo F. Padovan
2010-07-08 21:57 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo F. Padovan @ 2010-05-16 4:53 UTC (permalink / raw)
To: Julia Lawall
Cc: Marcel Holtmann, linux-bluetooth, linux-kernel, kernel-janitors
* Julia Lawall <julia@diku.dk> [2010-05-15 23:19:15 +0200]:
> From: Julia Lawall <julia@diku.dk>
>
> Use kmemdup when some other buffer is immediately copied into the
> allocated region.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression from,to,size,flag;
> statement S;
> @@
>
> - to = \(kmalloc\|kzalloc\)(size,flag);
> + to = kmemdup(from,size,flag);
> if (to==NULL || ...) S
> - memcpy(to, from, size);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/bluetooth/bcm203x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c
> --- a/drivers/bluetooth/bcm203x.c
> +++ b/drivers/bluetooth/bcm203x.c
> @@ -224,7 +224,7 @@ static int bcm203x_probe(struct usb_inte
>
> BT_DBG("firmware data %p size %zu", firmware->data, firmware->size);
>
> - data->fw_data = kmalloc(firmware->size, GFP_KERNEL);
> + data->fw_data = kmemdup(firmware->data, firmware->size, GFP_KERNEL);
> if (!data->fw_data) {
> BT_ERR("Can't allocate memory for firmware image");
> release_firmware(firmware);
> @@ -234,7 +234,6 @@ static int bcm203x_probe(struct usb_inte
> return -ENOMEM;
> }
>
> - memcpy(data->fw_data, firmware->data, firmware->size);
> data->fw_size = firmware->size;
> data->fw_sent = 0;
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://padovan.org
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 20/37] drivers/bluetooth: Use kmemdup
2010-05-15 21:19 [PATCH 20/37] drivers/bluetooth: Use kmemdup Julia Lawall
2010-05-16 4:53 ` Gustavo F. Padovan
@ 2010-07-08 21:57 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2010-07-08 21:57 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-bluetooth, linux-kernel, kernel-janitors
Hi Julia,
> Use kmemdup when some other buffer is immediately copied into the
> allocated region.
patch has been applied to bluetooth-next-2.6 tree. Thanks.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-08 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-15 21:19 [PATCH 20/37] drivers/bluetooth: Use kmemdup Julia Lawall
2010-05-16 4:53 ` Gustavo F. Padovan
2010-07-08 21:57 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).