linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Jose Antonio Santos Cadenas <santoscadenas@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Avoid multiple inclusions of adapter.h
Date: Mon, 17 May 2010 18:06:58 +0200	[thread overview]
Message-ID: <20100517160658.GA3788@jh-x301> (raw)
In-Reply-To: <1273747136-8816-1-git-send-email-santoscadenas@gmail.com>

Hi,

On Thu, May 13, 2010, Jose Antonio Santos Cadenas wrote:
> ---
>  src/adapter.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/src/adapter.h b/src/adapter.h
> index 9b4ce10..8812ed8 100644
> --- a/src/adapter.h
> +++ b/src/adapter.h
> @@ -22,6 +22,9 @@
>   *
>   */
>  
> +#ifndef __ADAPTER_H__
> +#define __ADAPTER_H__
> +
>  #include <bluetooth/bluetooth.h>
>  #include <dbus/dbus.h>
>  #include <glib.h>
> @@ -183,3 +186,5 @@ struct btd_adapter_ops {
>  int btd_register_adapter_ops(struct btd_adapter_ops *btd_adapter_ops);
>  void btd_adapter_cleanup_ops(struct btd_adapter_ops *btd_adapter_ops);
>  int adapter_ops_setup(void);
> +
> +#endif /* __ADAPTER_H__ */

Lack of these defines is actually intentional for headsers which aren't
part of any public library. The intention is to keep the header
dependencies simple and get errors as soon as there's a circular
dependency between them.

Johan

  reply	other threads:[~2010-05-17 16:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 10:38 [PATCH] Avoid multiple inclusions of adapter.h Jose Antonio Santos Cadenas
2010-05-17 16:06 ` Johan Hedberg [this message]
2010-05-18  9:57   ` José Antonio Santos Cadenas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100517160658.GA3788@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=santoscadenas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).