From: "José Antonio Santos Cadenas" <santoscadenas@gmail.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Avoid multiple inclusions of adapter.h
Date: Tue, 18 May 2010 11:57:32 +0200 [thread overview]
Message-ID: <201005181157.32835.santoscadenas@gmail.com> (raw)
In-Reply-To: <20100517160658.GA3788@jh-x301>
Hi,
El Monday 17 May 2010 18:06:58 Johan Hedberg escribió:
> Hi,
>
> On Thu, May 13, 2010, Jose Antonio Santos Cadenas wrote:
> > ---
> >
> > src/adapter.h | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/src/adapter.h b/src/adapter.h
> > index 9b4ce10..8812ed8 100644
> > --- a/src/adapter.h
> > +++ b/src/adapter.h
> > @@ -22,6 +22,9 @@
> >
> > *
> > */
> >
> > +#ifndef __ADAPTER_H__
> > +#define __ADAPTER_H__
> > +
> >
> > #include <bluetooth/bluetooth.h>
> > #include <dbus/dbus.h>
> > #include <glib.h>
> >
> > @@ -183,3 +186,5 @@ struct btd_adapter_ops {
> >
> > int btd_register_adapter_ops(struct btd_adapter_ops *btd_adapter_ops);
> > void btd_adapter_cleanup_ops(struct btd_adapter_ops *btd_adapter_ops);
> > int adapter_ops_setup(void);
> >
> > +
> > +#endif /* __ADAPTER_H__ */
>
> Lack of these defines is actually intentional for headsers which aren't
> part of any public library. The intention is to keep the header
> dependencies simple and get errors as soon as there's a circular
> dependency between them.
Thank you for the response. I guess I have to review how I do the include :)
>
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
> in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-05-18 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 10:38 [PATCH] Avoid multiple inclusions of adapter.h Jose Antonio Santos Cadenas
2010-05-17 16:06 ` Johan Hedberg
2010-05-18 9:57 ` José Antonio Santos Cadenas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005181157.32835.santoscadenas@gmail.com \
--to=santoscadenas@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).