[PATCH] gateway_server_remove should unref audio_adapter

[PATCH] gateway_server_remove should unref audio_adapter

[Zhu Yanhai]

gateway_server_remove should unrefer the adapter, not refer it.

Signed-off-by: Zhu Yanhai <yanhai.zhu@linux.intel.com>
---
 audio/manager.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/manager.c b/audio/manager.c
index 28fd8af..f6a98cd 100644
--- a/audio/manager.c
+++ b/audio/manager.c
@@ -932,7 +932,7 @@ static void gateway_server_remove(struct btd_adapter *adapter)
 		adp->hfp_hs_server = NULL;
 	}
 
-	audio_adapter_ref(adp);
+	audio_adapter_unref(adp);
 }
 
 static int a2dp_server_probe(struct btd_adapter *adapter)
-- 
1.6.2.2

Re: [PATCH] gateway_server_remove should unref audio_adapter

[Zhu Yanhai]

On 06/04/2010 04:19 PM, Zhu Yanhai wrote:
> gateway_server_remove should unrefer the adapter, not refer it.
>
> Signed-off-by: Zhu Yanhai<yanhai.zhu@linux.intel.com>
> ---
>   audio/manager.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/manager.c b/audio/manager.c
> index 28fd8af..f6a98cd 100644
> --- a/audio/manager.c
> +++ b/audio/manager.c
> @@ -932,7 +932,7 @@ static void gateway_server_remove(struct btd_adapter *adapter)
>   		adp->hfp_hs_server = NULL;
>   	}
>
> -	audio_adapter_ref(adp);
> +	audio_adapter_unref(adp);
>   }
>
>   static int a2dp_server_probe(struct btd_adapter *adapter)

The current BlueZ 4.65 can't register itself on DBUS after system 
resume, as the interface org.bluez.Adapter wasn't unregistered during 
system suspend due to the non-zero ref numbers.

Regards,
Zhu Yanhai

Re: [PATCH] gateway_server_remove should unref audio_adapter

[Johan Hedberg]

Hi,

On Fri, Jun 04, 2010, Zhu Yanhai wrote:
> gateway_server_remove should unrefer the adapter, not refer it.
> 
> Signed-off-by: Zhu Yanhai <yanhai.zhu@linux.intel.com>

We don't use Signed-off-by in userspace BlueZ. I fixed it manually for
you this time. Also try to start the summary line with "Fix ..." for any
bugfixes (take a look at the upstream git how I changed it). With those
commit message changes the patch has now been pushed upstream.

Johan

Re: [PATCH] gateway_server_remove should unref audio_adapter

[Zhu Yanhai]

On 06/04/2010 04:30 PM, Johan Hedberg wrote:
> Hi,
>
> On Fri, Jun 04, 2010, Zhu Yanhai wrote:
>> gateway_server_remove should unrefer the adapter, not refer it.
>>
>> Signed-off-by: Zhu Yanhai<yanhai.zhu@linux.intel.com>
>
> We don't use Signed-off-by in userspace BlueZ. I fixed it manually for
> you this time. Also try to start the summary line with "Fix ..." for any
> bugfixes (take a look at the upstream git how I changed it). With those
> commit message changes the patch has now been pushed upstream.
>
> Johan
>

Thank you Johan! I promise I will follow these next time :)

Regards,
Zhu Yanhai