From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Gustavo F. Padovan" <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/4] Fix regression with debug via SIGUSR2
Date: Fri, 4 Jun 2010 14:34:22 +0300 [thread overview]
Message-ID: <20100604113422.GA6118@jh-x301> (raw)
In-Reply-To: <1275646613-32639-1-git-send-email-gustavo@padovan.org>
Hi Gustavo,
On Fri, Jun 04, 2010, Gustavo F. Padovan wrote:
> +static void turn_debug_on(const char *debug)
Please call this simply debug_on()
> +static void turn_debug_off()
same here (debug_off)
> +void __btd_toogle_debug()
It's called toggle and not toogle :)
> + if (enabled == NULL)
> + turn_debug_on("*");
I suppose this should restore the previous value and not hard-code "*"?
Johan
next prev parent reply other threads:[~2010-06-04 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 10:16 [PATCH 1/4] Fix regression with debug via SIGUSR2 Gustavo F. Padovan
2010-06-04 10:16 ` [PATCH 2/4] Add debug_string and debug_enabled vars Gustavo F. Padovan
2010-06-04 10:16 ` [PATCH 3/4] log: Remove vinfo function Gustavo F. Padovan
2010-06-04 10:16 ` [PATCH 4/4] Adjust define name to the name of the file Gustavo F. Padovan
2010-06-04 10:59 ` Luiz Augusto von Dentz
2010-06-04 11:34 ` Johan Hedberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-05 2:23 [PATCH 1/4] Fix regression with debug via SIGUSR2 Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100604113422.GA6118@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).