From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Gustavo F. Padovan" <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/3] Remove ifndef barrier from log.h and btio.h
Date: Tue, 8 Jun 2010 14:19:54 +0800 [thread overview]
Message-ID: <20100608061954.GA16335@jh-x301> (raw)
In-Reply-To: <1275712886-20127-2-git-send-email-gustavo@padovan.org>
Hi Gustavo,
On Sat, Jun 05, 2010, Gustavo F. Padovan wrote:
> ---
> src/btio.h | 3 ---
> src/log.h | 4 +---
> 2 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/src/btio.h b/src/btio.h
> index 00d743e..fa6ff69 100644
> --- a/src/btio.h
> +++ b/src/btio.h
> @@ -21,8 +21,6 @@
> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> *
> */
> -#ifndef BT_IO_H
> -#define BT_IO_H
I think it'd be good to leave this for BtIO since it might become a
public library soon.
> -#ifndef __LOGGING_H
> -#define __LOGGING_H
> +extern int debug_enabled;
This doesn't match the commit message. To me it seems like the extern
int addition should be part of the third patch and not this one. Also,
Marcel might have had a reason for putting the safeguard for log.h so
just leave these safeguards as they are (ofono and connman has them
too).
Johan
next prev parent reply other threads:[~2010-06-08 6:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 4:41 [PATCH 1/3] log: Remove vinfo function Gustavo F. Padovan
2010-06-05 4:41 ` [PATCH 2/3] Remove ifndef barrier from log.h and btio.h Gustavo F. Padovan
2010-06-05 4:41 ` [PATCH 3/3] Fix regression with debug via SIGUSR2 Gustavo F. Padovan
2010-06-05 4:49 ` Gustavo F. Padovan
2010-06-05 4:51 ` [PATCH] " Gustavo F. Padovan
2010-06-08 6:19 ` Johan Hedberg [this message]
2010-06-08 7:14 ` [PATCH 2/3] Remove ifndef barrier from log.h and btio.h Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100608061954.GA16335@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).