From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Siarhei Siamashka <siarhei.siamashka@gmail.com>,
linux-bluetooth@vger.kernel.org,
Lennart Poettering <lennart@poettering.net>
Subject: Re: SBC encoder/decoder API & errors handling
Date: Wed, 30 Jun 2010 11:53:47 +0300 [thread overview]
Message-ID: <20100630085347.GA31839@jh-x301> (raw)
In-Reply-To: <AANLkTildwDBZR2U6AtxGEiq4Mv-PBnDoqY1xfqHHmzL2@mail.gmail.com>
Hi Luiz,
On Wed, Jun 30, 2010, Luiz Augusto von Dentz wrote:
> audio/pcm_bluetooth.c:1060: encoded = sbc_encode(&a2dp->sbc,
> data->buffer, a2dp->codesize,
> audio/pcm_bluetooth.c:1096: encoded = sbc_encode(&a2dp->sbc, buff,
> a2dp->codesize,
My patch already contained the fix for these two.
> audio/gstsbcenc.c:391: consumed = sbc_encode(&enc->sbc, (gpointer) data,
This place actually passes NULL as the output parameter so no issue
there.
I'll push in a minute the fix in two separate commits (the libsbc
changes should be in an independent patch so they can easily be exported
to external copies like pulseaudio).
Johan
next prev parent reply other threads:[~2010-06-30 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 18:45 SBC encoder/decoder API & errors handling Siarhei Siamashka
2010-06-30 7:53 ` Johan Hedberg
2010-06-30 8:31 ` Luiz Augusto von Dentz
2010-06-30 8:53 ` Johan Hedberg [this message]
2010-06-30 13:07 ` Siarhei Siamashka
2010-06-30 11:03 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630085347.GA31839@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=lennart@poettering.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=siarhei.siamashka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).