From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vladimir Davydov <vladimir.davydov@promwad.com>
Cc: linux-bluetooth@vger.kernel.org,
Sergey Kovalev <sergey.kovalev@promwad.com>
Subject: Re: [PATCH] hciattach: Fix the timeout handling code
Date: Wed, 30 Jun 2010 14:46:29 +0300 [thread overview]
Message-ID: <20100630114629.GA5961@jh-x301> (raw)
In-Reply-To: <201006301441.25119.vladimir.davydov@promwad.com>
Hi Vladimir,
On Wed, Jun 30, 2010, Vladimir Davydov wrote:
> From: Vladimir Davydov <vladimir.davydov@promwad.com>
>
> The variable 'retries' should be defined as static, or it will be always 0.
The patch doesn't apply cleanly:
Applying: hciattach: Fix the timeout handling code
fatal: corrupt patch at line 13
Patch failed at 0001 hciattach: Fix the timeout handling code
Maybe you could try git send-email instead?
> Signed-off-by: Vladimir Davydov <vladimir.davydov@promwad.com>
We don't use Signed-off-by in the userspace part of BlueZ, so please leave it
away. Otherwise the patch looked fine.
Johan
next prev parent reply other threads:[~2010-06-30 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 11:41 [PATCH] hciattach: Fix the timeout handling code Vladimir Davydov
2010-06-30 11:46 ` Johan Hedberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-30 13:21 Vladimir Davydov
2010-06-30 14:39 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100630114629.GA5961@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sergey.kovalev@promwad.com \
--cc=vladimir.davydov@promwad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).