linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Hedberg Johan (Nokia-D/Helsinki)" <johan.hedberg@gmail.com>
To: Dmitriy Paliy <dmitriy.paliy@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix signal strength for HFP in maemo6 telephony
Date: Mon, 12 Jul 2010 14:31:06 -0300	[thread overview]
Message-ID: <20100712173106.GA18755@jh-x301> (raw)
In-Reply-To: <1278954283-3832-1-git-send-email-dmitriy.paliy@nokia.com>

Hi Dmitriy,

On Mon, Jul 12, 2010, Dmitriy Paliy wrote:
> Signal strength in terms of bars units is updated by emited
> SignalBarsChanged instead of SignalStrengthChanged from libscnet library.
> It contains required number of bars to display in scale 0..5. Conversion
> from percent or decibel units to bars is not needed and therefore removed.
> 
> Same holds when initializing by request of SignalBars, where bars are in
> 0..5 range. Conversion from percents is removed. Sanity check is done to
> prevent -1 that may be returned when the property is unavailabe (modem
> state off).
> 
> RSSI percents and dBs are neither present among SignalBarsChanged
> properties nor requested during initialization and, therefore, removed.
> ---
>  audio/telephony-maemo6.c |   20 +++++++++-----------
>  1 files changed, 9 insertions(+), 11 deletions(-)

This patch has been pushed upstream. Thanks.

Johan

  reply	other threads:[~2010-07-12 17:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12 17:04 [PATCH 1/2] Fix signal strength for HFP in maemo6 telephony Dmitriy Paliy
2010-07-12 17:31 ` Hedberg Johan (Nokia-D/Helsinki) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-07-09 14:44 [PATCH] Fix signal strength for HFP in maemo6 telephony due to changed API in libcsnet Dmitriy Paliy
2010-07-11 21:17 ` [PATCH 1/2] Fix signal strength for HFP in maemo6 telephony Dmitriy Paliy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100712173106.GA18755@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=dmitriy.paliy@nokia.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).