bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Hello

bluez installs stuff into /etc/alsa and it seems wrong since default
location for alsa stuff seems to be /usr/share/alsa instead. You can
also see that this is been workarounded in ubuntu, gentoo (and probably
debian also).

Any reason why using /etc/alsa instead?

Thanks a lot

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Marcel Holtmann]

Hi Pacho,

> bluez installs stuff into /etc/alsa and it seems wrong since default
> location for alsa stuff seems to be /usr/share/alsa instead. You can
> also see that this is been workarounded in ubuntu, gentoo (and probably
> debian also).
> 
> Any reason why using /etc/alsa instead?

I thought that is the default location. If that is wrong, then please
quote the ALSA documentation and send a patch to fix it.

Regards

Marcel

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

El jue, 04-03-2010 a las 17:42 -0800, Marcel Holtmann escribió:
> Hi Pacho,
> 
> > bluez installs stuff into /etc/alsa and it seems wrong since default
> > location for alsa stuff seems to be /usr/share/alsa instead. You can
> > also see that this is been workarounded in ubuntu, gentoo (and probably
> > debian also).
> > 
> > Any reason why using /etc/alsa instead?
> 
> I thought that is the default location. If that is wrong, then please
> quote the ALSA documentation and send a patch to fix it.
> 
> Regards
> 
> Marcel

alsa-lib configure.in seems to indicate that /usr/share/alsa is the
default one:
dnl ALSA configuration directory
AC_ARG_WITH(configdir,
    AS_HELP_STRING([--with-configdir=dir],
        [path where ALSA config files are stored]),
    confdir="$withval", confdir="")
if test -z "$confdir"; then
    eval dir="$datadir"
    case "$dir" in
    /*) ;;
    *) dir="$prefix/share"
    esac
    confdir="$dir/alsa"
fi


[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Pacho Ramos]

[-- Attachment #1.1: Type: text/plain, Size: 1135 bytes --]

El vie, 05-03-2010 a las 10:11 +0100, Pacho Ramos escribió:
> El jue, 04-03-2010 a las 17:42 -0800, Marcel Holtmann escribió:
> > Hi Pacho,
> > 
> > > bluez installs stuff into /etc/alsa and it seems wrong since default
> > > location for alsa stuff seems to be /usr/share/alsa instead. You can
> > > also see that this is been workarounded in ubuntu, gentoo (and probably
> > > debian also).
> > > 
> > > Any reason why using /etc/alsa instead?
> > 
> > I thought that is the default location. If that is wrong, then please
> > quote the ALSA documentation and send a patch to fix it.
> > 
> > Regards
> > 
> > Marcel
> 
> alsa-lib configure.in seems to indicate that /usr/share/alsa is the
> default one:
> dnl ALSA configuration directory
> AC_ARG_WITH(configdir,
>     AS_HELP_STRING([--with-configdir=dir],
>         [path where ALSA config files are stored]),
>     confdir="$withval", confdir="")
> if test -z "$confdir"; then
>     eval dir="$datadir"
>     case "$dir" in
>     /*) ;;
>     *) dir="$prefix/share"
>     esac
>     confdir="$dir/alsa"
> fi
> 

I forgot the patch, sorry


[-- Attachment #1.2: bluez-4.61-alsa.patch --]
[-- Type: text/x-patch, Size: 330 bytes --]

--- Makefile.am~	2010-02-12 20:26:48.000000000 +0100
+++ Makefile.am	2010-03-05 10:17:15.000000000 +0100
@@ -241,7 +241,7 @@
 audio_libasound_module_ctl_bluetooth_la_CFLAGS = @ALSA_CFLAGS@
 
 if CONFIGFILES
-alsaconfdir = $(sysconfdir)/alsa
+alsaconfdir = $(datadir)/alsa
 
 alsaconf_DATA = audio/bluetooth.conf
 endif

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

El vie, 05-03-2010 a las 10:24 +0100, Pacho Ramos escribió:
> El vie, 05-03-2010 a las 10:11 +0100, Pacho Ramos escribió:
> > El jue, 04-03-2010 a las 17:42 -0800, Marcel Holtmann escribió:
> > > Hi Pacho,
> > > 
> > > > bluez installs stuff into /etc/alsa and it seems wrong since default
> > > > location for alsa stuff seems to be /usr/share/alsa instead. You can
> > > > also see that this is been workarounded in ubuntu, gentoo (and probably
> > > > debian also).
> > > > 
> > > > Any reason why using /etc/alsa instead?
> > > 
> > > I thought that is the default location. If that is wrong, then please
> > > quote the ALSA documentation and send a patch to fix it.
> > > 
> > > Regards
> > > 
> > > Marcel
> > 
> > alsa-lib configure.in seems to indicate that /usr/share/alsa is the
> > default one:
> > dnl ALSA configuration directory
> > AC_ARG_WITH(configdir,
> >     AS_HELP_STRING([--with-configdir=dir],
> >         [path where ALSA config files are stored]),
> >     confdir="$withval", confdir="")
> > if test -z "$confdir"; then
> >     eval dir="$datadir"
> >     case "$dir" in
> >     /*) ;;
> >     *) dir="$prefix/share"
> >     esac
> >     confdir="$dir/alsa"
> > fi
> > 
> 
> I forgot the patch, sorry
> 

Was this committed finally? Thanks :-)

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

El sáb, 10-04-2010 a las 13:28 +0200, Pacho Ramos escribió:
> El vie, 05-03-2010 a las 10:24 +0100, Pacho Ramos escribió:
> > El vie, 05-03-2010 a las 10:11 +0100, Pacho Ramos escribió:
> > > El jue, 04-03-2010 a las 17:42 -0800, Marcel Holtmann escribió:
> > > > Hi Pacho,
> > > > 
> > > > > bluez installs stuff into /etc/alsa and it seems wrong since default
> > > > > location for alsa stuff seems to be /usr/share/alsa instead. You can
> > > > > also see that this is been workarounded in ubuntu, gentoo (and probably
> > > > > debian also).
> > > > > 
> > > > > Any reason why using /etc/alsa instead?
> > > > 
> > > > I thought that is the default location. If that is wrong, then please
> > > > quote the ALSA documentation and send a patch to fix it.
> > > > 
> > > > Regards
> > > > 
> > > > Marcel
> > > 
> > > alsa-lib configure.in seems to indicate that /usr/share/alsa is the
> > > default one:
> > > dnl ALSA configuration directory
> > > AC_ARG_WITH(configdir,
> > >     AS_HELP_STRING([--with-configdir=dir],
> > >         [path where ALSA config files are stored]),
> > >     confdir="$withval", confdir="")
> > > if test -z "$confdir"; then
> > >     eval dir="$datadir"
> > >     case "$dir" in
> > >     /*) ;;
> > >     *) dir="$prefix/share"
> > >     esac
> > >     confdir="$dir/alsa"
> > > fi
> > > 
> > 
> > I forgot the patch, sorry
> > 

Can this be finally committed please? Thanks a lot :-)


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Johan Hedberg]

On Fri, Jul 16, 2010, Pacho Ramos wrote:
> Can this be finally committed please? Thanks a lot :-)

It's strange the the patch has gone unnoticed ever since March. Anyway,
could you please provide a git format-patch version of it since that's
the convention for all patch submisions. That way I don't need to play
manual tricks to get the git author name and email correct for the
commit.

Johan

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

El vie, 16-07-2010 a las 14:01 -0300, Johan Hedberg escribió:
> 
> On Fri, Jul 16, 2010, Pacho Ramos wrote:
> > Can this be finally committed please? Thanks a lot :-)
> 
> It's strange the the patch has gone unnoticed ever since March. Anyway,
> could you please provide a git format-patch version of it since that's
> the convention for all patch submisions. That way I don't need to play
> manual tricks to get the git author name and email correct for the
> commit.
> 
> Johan
> 

Sadly I have always failed to create patches in a git format-patch
version :'(

This is what I have tried:
$ git clone git://git.kernel.org/pub/scm/bluetooth/bluez.git
Initialized empty Git repository in /home/pacho/bluez/.git/
remote: Counting objects: 35451, done.
remote: Compressing objects: 100% (8577/8577), done.
remote: Total 35451 (delta 27190), reused 34976 (delta 26858)
Receiving objects: 100% (35451/35451), 6.16 MiB | 1.39 MiB/s, done.
Resolving deltas: 100% (27190/27190), done.
$ cd bluez/
$ git checkout -b fix_alsa_path
Switched to a new branch 'fix_alsa_path'
$ patch -p0
</usr/portage/net-wireless/bluez/files/bluez-alsa_location.patch 
patching file Makefile.am
Hunk #1 succeeded at 248 (offset 7 lines).
$ git format-patch master --stdout
$ (nothing is shown)



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Gustavo F. Padovan]

Hi Pacho,

* Pacho Ramos <pacho@condmat1.ciencias.uniovi.es> [2010-07-16 19:21:45 +020=
0]:

> El vie, 16-07-2010 a las 14:01 -0300, Johan Hedberg escribi=F3:
> >=20
> > On Fri, Jul 16, 2010, Pacho Ramos wrote:
> > > Can this be finally committed please? Thanks a lot :-)
> >=20
> > It's strange the the patch has gone unnoticed ever since March. Anyway,
> > could you please provide a git format-patch version of it since that's
> > the convention for all patch submisions. That way I don't need to play
> > manual tricks to get the git author name and email correct for the
> > commit.
> >=20
> > Johan
> >=20
>=20
> Sadly I have always failed to create patches in a git format-patch
> version :'(
>=20
> This is what I have tried:
> $ git clone git://git.kernel.org/pub/scm/bluetooth/bluez.git
> Initialized empty Git repository in /home/pacho/bluez/.git/
> remote: Counting objects: 35451, done.
> remote: Compressing objects: 100% (8577/8577), done.
> remote: Total 35451 (delta 27190), reused 34976 (delta 26858)
> Receiving objects: 100% (35451/35451), 6.16 MiB | 1.39 MiB/s, done.
> Resolving deltas: 100% (27190/27190), done.
> $ cd bluez/
> $ git checkout -b fix_alsa_path
> Switched to a new branch 'fix_alsa_path'
> $ patch -p0
> </usr/portage/net-wireless/bluez/files/bluez-alsa_location.patch=20
> patching file Makefile.am
> Hunk #1 succeeded at 248 (offset 7 lines).
> $ git format-patch master --stdout
> $ (nothing is shown)

If your patch is on HEAD then just do:

git format-patch -1

and then use 'git send-email' to send it to the mailing list.

--=20
Gustavo F. Padovan
http://padovan.org

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Pacho Ramos]

[-- Attachment #1.1: Type: text/plain, Size: 1823 bytes --]

El vie, 16-07-2010 a las 15:08 -0300, Gustavo F. Padovan escribió:
> Hi Pacho,
> 
> * Pacho Ramos <pacho@condmat1.ciencias.uniovi.es> [2010-07-16 19:21:45 +0200]:
> 
> > El vie, 16-07-2010 a las 14:01 -0300, Johan Hedberg escribió:
> > > 
> > > On Fri, Jul 16, 2010, Pacho Ramos wrote:
> > > > Can this be finally committed please? Thanks a lot :-)
> > > 
> > > It's strange the the patch has gone unnoticed ever since March. Anyway,
> > > could you please provide a git format-patch version of it since that's
> > > the convention for all patch submisions. That way I don't need to play
> > > manual tricks to get the git author name and email correct for the
> > > commit.
> > > 
> > > Johan
> > > 
> > 
> > Sadly I have always failed to create patches in a git format-patch
> > version :'(
> > 
> > This is what I have tried:
> > $ git clone git://git.kernel.org/pub/scm/bluetooth/bluez.git
> > Initialized empty Git repository in /home/pacho/bluez/.git/
> > remote: Counting objects: 35451, done.
> > remote: Compressing objects: 100% (8577/8577), done.
> > remote: Total 35451 (delta 27190), reused 34976 (delta 26858)
> > Receiving objects: 100% (35451/35451), 6.16 MiB | 1.39 MiB/s, done.
> > Resolving deltas: 100% (27190/27190), done.
> > $ cd bluez/
> > $ git checkout -b fix_alsa_path
> > Switched to a new branch 'fix_alsa_path'
> > $ patch -p0
> > </usr/portage/net-wireless/bluez/files/bluez-alsa_location.patch 
> > patching file Makefile.am
> > Hunk #1 succeeded at 248 (offset 7 lines).
> > $ git format-patch master --stdout
> > $ (nothing is shown)
> 
> If your patch is on HEAD then just do:
> 
> git format-patch -1
> 
> and then use 'git send-email' to send it to the mailing list.
> 

Seems I forgot to commit ;-), I attach the patch

Thanks :-)


[-- Attachment #1.2: 0001-Install-alsa-stuff-in-correct-place.patch --]
[-- Type: text/x-patch, Size: 731 bytes --]

From 4421d83d1d5cd0875ec12457f621a31fdc8862a1 Mon Sep 17 00:00:00 2001
From: Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>
Date: Fri, 16 Jul 2010 20:38:58 +0200
Subject: [PATCH] Install alsa stuff in correct place

---
 Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index f4bf87d..65d4312 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -248,7 +248,7 @@ audio_libasound_module_ctl_bluetooth_la_LIBADD = lib/libbluetooth.la @ALSA_LIBS@
 audio_libasound_module_ctl_bluetooth_la_CFLAGS = @ALSA_CFLAGS@
 
 if CONFIGFILES
-alsaconfdir = $(sysconfdir)/alsa
+alsaconfdir = $(datadir)/alsa
 
 alsaconf_DATA = audio/bluetooth.conf
 endif
-- 
1.7.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Johan Hedberg]

Hi,

On Fri, Jul 16, 2010, Pacho Ramos wrote:
> From: Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>
> Date: Fri, 16 Jul 2010 20:38:58 +0200
> Subject: [PATCH] Install alsa stuff in correct place
> 
> ---
>  Makefile.am |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

The patch is now upstream. Thanks.

Johan

Re: bluez installs alsa related stuff under /etc/alsa instead of /usr/share/alsa

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

El vie, 16-07-2010 a las 20:44 -0300, Johan Hedberg escribió:
> Hi,
> 
> On Fri, Jul 16, 2010, Pacho Ramos wrote:
> > From: Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>
> > Date: Fri, 16 Jul 2010 20:38:58 +0200
> > Subject: [PATCH] Install alsa stuff in correct place
> > 
> > ---
> >  Makefile.am |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> The patch is now upstream. Thanks.
> 
> Johan

Great, thanks for committing :-)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]