From: "Gustavo F. Padovan" <gustavo@padovan.org>
To: Dan Carpenter <error27@gmail.com>
Cc: "Marcel Holtmann" <marcel@holtmann.org>,
"David S. Miller" <davem@davemloft.net>,
"Gustavo F. Padovan" <padovan@profusion.mobi>,
"João Paulo Rechi Vita" <jprvita@profusion.mobi>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] l2cap: fix signedness bugs
Date: Sat, 17 Jul 2010 14:51:40 -0300 [thread overview]
Message-ID: <20100717175139.GF16892@vigoh> (raw)
In-Reply-To: <20100717170548.GH17585@bicker>
Hi Dan,
* Dan Carpenter <error27@gmail.com> [2010-07-17 19:05:48 +0200]:
> These variables are only used for math. They should be from -63 to +63.
> In the original code instead of being negative they would be largish
> positive numbers. I changed them to ints.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
> index 1b682a5..4a13499 100644
> --- a/net/bluetooth/l2cap.c
> +++ b/net/bluetooth/l2cap.c
> @@ -3795,7 +3795,7 @@ static inline int l2cap_data_channel_iframe(struct sock *sk, u16 rx_control, str
> u8 tx_seq = __get_txseq(rx_control);
> u8 req_seq = __get_reqseq(rx_control);
> u8 sar = rx_control >> L2CAP_CTRL_SAR_SHIFT;
> - u8 tx_seq_offset, expected_tx_seq_offset;
> + int tx_seq_offset, expected_tx_seq_offset;
> int num_to_ack = (pi->tx_win/6) + 1;
> int err = 0;
>
> @@ -4080,7 +4080,7 @@ static inline int l2cap_data_channel(struct l2cap_conn *conn, u16 cid, struct sk
> struct sock *sk;
> struct l2cap_pinfo *pi;
> u16 control, len;
> - u8 tx_seq, req_seq, next_tx_seq_offset, req_seq_offset;
> + int tx_seq, req_seq, next_tx_seq_offset, req_seq_offset;
>
> sk = l2cap_get_chan_by_scid(&conn->chan_list, cid);
> if (!sk) {
I fixed this already. Thanks.
--
Gustavo F. Padovan
http://padovan.org
prev parent reply other threads:[~2010-07-17 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-17 17:05 [patch] l2cap: fix signedness bugs Dan Carpenter
2010-07-17 17:51 ` Gustavo F. Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100717175139.GF16892@vigoh \
--to=gustavo@padovan.org \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=jprvita@profusion.mobi \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).