* [patch -next] bluetooth/hci_ath: kfree() => kfree_skb()
@ 2010-07-23 10:11 Dan Carpenter
2010-07-23 18:10 ` Gustavo F. Padovan
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2010-07-23 10:11 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: Suraj Sumangala, linux-bluetooth, kernel-janitors
sk_buffs have to be freed with kfree_skb() instead of kfree().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
index 5ab258b..74a8f61 100755
--- a/drivers/bluetooth/hci_ath.c
+++ b/drivers/bluetooth/hci_ath.c
@@ -163,7 +163,7 @@ static int ath_enqueue(struct hci_uart *hu, struct sk_buff *skb)
struct ath_struct *ath = hu->priv;
if (bt_cb(skb)->pkt_type == HCI_SCODATA_PKT) {
- kfree(skb);
+ kfree_skb(skb);
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch -next] bluetooth/hci_ath: kfree() => kfree_skb()
2010-07-23 10:11 [patch -next] bluetooth/hci_ath: kfree() => kfree_skb() Dan Carpenter
@ 2010-07-23 18:10 ` Gustavo F. Padovan
2010-07-27 22:28 ` Marcel Holtmann
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo F. Padovan @ 2010-07-23 18:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: Marcel Holtmann, Suraj Sumangala, linux-bluetooth,
kernel-janitors
Hi Dan,
* Dan Carpenter <error27@gmail.com> [2010-07-23 12:11:04 +0200]:
> sk_buffs have to be freed with kfree_skb() instead of kfree().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
> index 5ab258b..74a8f61 100755
> --- a/drivers/bluetooth/hci_ath.c
> +++ b/drivers/bluetooth/hci_ath.c
> @@ -163,7 +163,7 @@ static int ath_enqueue(struct hci_uart *hu, struct sk_buff *skb)
> struct ath_struct *ath = hu->priv;
>
> if (bt_cb(skb)->pkt_type == HCI_SCODATA_PKT) {
> - kfree(skb);
> + kfree_skb(skb);
> return 0;
> }
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
http://padovan.org
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch -next] bluetooth/hci_ath: kfree() => kfree_skb()
2010-07-23 18:10 ` Gustavo F. Padovan
@ 2010-07-27 22:28 ` Marcel Holtmann
0 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2010-07-27 22:28 UTC (permalink / raw)
To: Gustavo F. Padovan
Cc: Dan Carpenter, Suraj Sumangala, linux-bluetooth, kernel-janitors
Hi Dan,
> > sk_buffs have to be freed with kfree_skb() instead of kfree().
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
> > index 5ab258b..74a8f61 100755
> > --- a/drivers/bluetooth/hci_ath.c
> > +++ b/drivers/bluetooth/hci_ath.c
> > @@ -163,7 +163,7 @@ static int ath_enqueue(struct hci_uart *hu, struct sk_buff *skb)
> > struct ath_struct *ath = hu->priv;
> >
> > if (bt_cb(skb)->pkt_type == HCI_SCODATA_PKT) {
> > - kfree(skb);
> > + kfree_skb(skb);
> > return 0;
> > }
>
> Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
patch has been applied. Thanks.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-27 22:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-23 10:11 [patch -next] bluetooth/hci_ath: kfree() => kfree_skb() Dan Carpenter
2010-07-23 18:10 ` Gustavo F. Padovan
2010-07-27 22:28 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).