From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Mol <marcel@mesa.nl>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] obexd: ebook backend: return all TEL attribs from vcard in string
Date: Tue, 3 Aug 2010 00:57:12 +0300 [thread overview]
Message-ID: <20100802215712.GA3392@jh-x301> (raw)
In-Reply-To: <201008022131.o72LVpuL011014@joshua.mesa.nl>
On Mon, Aug 02, 2010, Marcel Mol wrote:
> + for (; l; l = g_list_next(l)) {
> + EVCardAttribute *attrib = l->data;
> if (!attrib)
> continue;
Add an empty line after variable declarations.
> -
> - e_vcard_add_attribute(evcard2, e_vcard_attribute_copy(attrib));
> + const char *name = e_vcard_attribute_get_name(attrib);
plugins/phonebook.c: In function ‘evcard_to_string’:
plugins/phonebook.c:119: error: ISO C90 forbids mixed declarations and code
make[1]: *** [plugins/phonebook.o] Error 1
make: *** [all] Error 2
> + for (i = 0; attribute_mask[i] != NULL; i++) {
> + if (!(filter & (1 << i)))
> + continue;
> + if (g_strcmp(name, attribute_mask[i]) != 0)
plugins/phonebook.c:123: error: implicit declaration of function ‘g_strcmp’
Probably some missing include. Furthermore, use g_strcmp0 if there's a
risk that one of the inputs might be NULL.
Always compile test with ./bootstrap-configure (in this case
--with-phonebook=ebook) before submitting patches.
Johan
next prev parent reply other threads:[~2010-08-02 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 21:29 [PATCH] obexd: ebook backend: return all TEL attribs from vcard in string Marcel Mol
2010-08-02 21:57 ` Johan Hedberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-08-02 22:08 Marcel Mol
2010-08-02 22:20 ` Johan Hedberg
2010-08-02 21:29 Marcel Mol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802215712.GA3392@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@mesa.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).