From: Johan Hedberg <johan.hedberg@gmail.com>
To: Inga Stotland <ingas@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, rshaffer@codeaurora.org,
marcel@holtmann.org
Subject: Re: [PATCH 4/6] Fix in logic to write EIR when SDP records are changed.
Date: Tue, 3 Aug 2010 11:23:23 +0300 [thread overview]
Message-ID: <20100803082323.GC5831@jh-x301> (raw)
In-Reply-To: <1280576713-1398-5-git-send-email-ingas@codeaurora.org>
Hi Inga,
On Sat, Jul 31, 2010, Inga Stotland wrote:
> Whenver SDP service record is added/deleted/modified check for whether
> class of device needs to be updated as well. If the update is
> needed, proceed as before and new EIR will be written subsequently.
> If the class of device is already present, just update EIR and return.
> ---
> src/adapter.c | 14 ++++++++++----
> 1 files changed, 10 insertions(+), 4 deletions(-)
A few minor coding style issues
> - /* If we already have the CoD we want or the cache is enabled or an
> - * existing CoD write is in progress just bail out */
> - if (adapter->current_cod == adapter->wanted_cod ||
> - adapter->cache_enable || adapter->pending_cod)
> + /* If the cache is enabled or an existing CoD write is in progress
> + * just bail out */
> + if(adapter->cache_enable || adapter->pending_cod)
Missing space beteween if and (
> return 0;
Add an empty line here.
> + /* If we already have the CoD we want, update EIR and return */
> + if (adapter->current_cod == adapter->wanted_cod) {
> + update_ext_inquiry_response(adapter);
> + return 0;
> + }
Johan
next prev parent reply other threads:[~2010-08-03 8:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 11:45 [PATCH v5 0/6] Enhanced support for extended inquiry response Inga Stotland
2010-07-31 11:45 ` [PATCH 1/6] Spec constants for Extended Inquiry Response field types Inga Stotland
2010-07-31 11:45 ` [PATCH 2/6] Clean up code that generates extended inquiry response Inga Stotland
2010-08-03 8:12 ` Johan Hedberg
2010-08-03 15:37 ` ingas
2010-08-03 16:26 ` Johan Hedberg
2010-07-31 11:45 ` [PATCH 3/6] Support for adding UUID128 to " Inga Stotland
2010-08-03 8:18 ` Johan Hedberg
2010-07-31 11:45 ` [PATCH 4/6] Fix in logic to write EIR when SDP records are changed Inga Stotland
2010-08-03 8:23 ` Johan Hedberg [this message]
2010-07-31 11:45 ` [PATCH 5/6] Handle arrays in device properties dictionary Inga Stotland
2010-07-31 11:45 ` [PATCH 6/6] Support for generating dictionary value of service UUIDs Inga Stotland
2010-08-03 8:36 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803082323.GC5831@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=ingas@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=rshaffer@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox