From: Johan Hedberg <johan.hedberg@gmail.com>
To: Inga Stotland <ingas@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, rshaffer@codeaurora.org,
marcel@holtmann.org
Subject: Re: [PATCH 3/7] Clean up code that generates extended inquiry response.
Date: Wed, 4 Aug 2010 17:07:20 +0300 [thread overview]
Message-ID: <20100804140720.GA14996@jh-x301> (raw)
In-Reply-To: <1280880237-2296-4-git-send-email-ingas@codeaurora.org>
Hi Inga,
The patches are starting to look pretty good. A couple more coding style
issues though (in this and a few consequtive emails):
On Tue, Aug 03, 2010, Inga Stotland wrote:
> + ptr[1] = (truncated) ? EIR_UUID16_SOME : EIR_UUID16_ALL;
Another patch in your patch set "fixes" this and removes the parenthesis
around truncated. Could you just fix it in this patch itself. In general
patches with fixes to other patches that aren't yet upstream should be
avoided by redoing the the first patch that caused the need for a fix to
begin with.
Johan
next prev parent reply other threads:[~2010-08-04 14:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 0:03 [PATCH v6 0/7] Enhanced support for extended inquiry response Inga Stotland
2010-08-04 0:03 ` [PATCH 1/7] Spec constants for Extended Inquiry Response field types Inga Stotland
2010-08-04 0:03 ` [PATCH 2/7] Minor fix when skipping duplicate UUID16 from EIR Inga Stotland
2010-08-04 0:03 ` [PATCH 3/7] Clean up code that generates extended inquiry response Inga Stotland
2010-08-04 14:07 ` Johan Hedberg [this message]
2010-08-04 0:03 ` [PATCH 4/7] Support for adding UUID128 to " Inga Stotland
2010-08-04 14:08 ` Johan Hedberg
2010-08-04 0:03 ` [PATCH 5/7] Fix in logic to write EIR when SDP records are changed Inga Stotland
2010-08-04 14:09 ` Johan Hedberg
2010-08-04 0:03 ` [PATCH 6/7] Handle arrays in device properties dictionary Inga Stotland
2010-08-04 0:03 ` [PATCH 7/7] Add service UUIDs from EIR to device properties in "Device Found" signal Inga Stotland
-- strict thread matches above, loose matches on Subject: below --
2010-08-04 17:07 [PATCH v7 0/7] Enhanced support for extended inquiry response Inga Stotland
2010-08-04 17:07 ` [PATCH 3/7] Clean up code that generates " Inga Stotland
2010-08-04 23:00 [PATCH v8 0/7] Enhanced support for " Inga Stotland
2010-08-04 23:00 ` [PATCH 3/7] Clean up code that generates " Inga Stotland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804140720.GA14996@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=ingas@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=rshaffer@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).