Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Inga Stotland <ingas@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, rshaffer@codeaurora.org,
	marcel@holtmann.org
Subject: Re: [PATCH v7 0/7] Enhanced support for extended inquiry response
Date: Wed, 4 Aug 2010 22:04:39 +0300	[thread overview]
Message-ID: <20100804190439.GA18786@jh-x301> (raw)
In-Reply-To: <1280941655-14313-1-git-send-email-ingas@codeaurora.org>

Hi Inga,

On Wed, Aug 04, 2010, Inga Stotland wrote:
> EIR needs to be updated whenever local SDP record database changes.
> Previously, when an SDP record was added/removed/updated, EIR would 
> be written in callback fired off HCI "Command Complete" event set off by
> "Write Class Of Device" command. However, if the class of device did not
> need to be updated, the EIR write was not happening either. This
> implementation has been augmented to write new EIR when modification
> in SDP database does not lead to updating of class of device.
> 
> Added support for UUID128 service descriptors in local EIR. 
> 
> Service UUIDs are written to "device properties" dictionary  when emitting
> "Device Found" signal. This allows peek at available services offered by 
> a remote device without establishing SDP connection.

There seems to be two "4/7" patches with the same summary line but
different content. What's going on? The patches apply cleanly but the
commit messages should match the content before I can push upstream.
Other than that and one other minor thing (I'll send another email about
it) the patches are starting to look like upstreamable quality. Thanks
for bearing with me and doing all the requested fixes (which I imagine
can feel overly pedantic at times) :)

Johan

  parent reply	other threads:[~2010-08-04 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-04 17:07 [PATCH v7 0/7] Enhanced support for extended inquiry response Inga Stotland
2010-08-04 17:07 ` [PATCH 1/7] Spec constants for Extended Inquiry Response field types Inga Stotland
2010-08-04 17:07 ` [PATCH 2/7] Minor fix when skipping duplicate UUID16 from EIR Inga Stotland
2010-08-04 17:07 ` [PATCH 3/7] Clean up code that generates extended inquiry response Inga Stotland
2010-08-04 17:07 ` [PATCH 4/7] Support for adding UUID128 to " Inga Stotland
2010-08-04 17:07 ` Inga Stotland
2010-08-04 17:07 ` [PATCH 6/7] Handle arrays in device properties dictionary Inga Stotland
2010-08-04 17:07 ` [PATCH 7/7] Add service UUIDs from EIR to device properties in "Device Found" signal Inga Stotland
2010-08-04 19:11   ` Johan Hedberg
2010-08-04 19:04 ` Johan Hedberg [this message]
2010-08-04 20:59   ` [PATCH v7 0/7] Enhanced support for extended inquiry response ingas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100804190439.GA18786@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=ingas@codeaurora.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=rshaffer@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox