Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: David Scherba <dscherba@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
	rshaffer@codeaurora.org
Subject: Re: [PATCH 1/2] Remove non-functional hci_devinfo calls in init_device()
Date: Mon, 9 Aug 2010 17:51:49 -0400	[thread overview]
Message-ID: <20100809215149.GA25488@jh-x301> (raw)
In-Reply-To: <1281388059-15945-2-git-send-email-dscherba@codeaurora.org>

Hi David,

On Mon, Aug 09, 2010, David Scherba wrote:
> ---
>  plugins/hciops.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/plugins/hciops.c b/plugins/hciops.c
> index 5775cf1..b38c056 100644
> --- a/plugins/hciops.c
> +++ b/plugins/hciops.c
> @@ -175,12 +175,6 @@ static void init_device(int index)
>  		goto fail;
>  	}
>  
> -	if (hci_devinfo(index, &di) < 0)
> -		goto fail;
> -
> -	if (hci_test_bit(HCI_RAW, &di.flags))
> -		goto done;
> -
>  done:
>  	hci_close_dev(dd);
>  	exit(0);

Nice catch, but that's not quite enough:

plugins/hciops.c: In function ‘init_device’:
plugins/hciops.c:178: error: label ‘done’ defined but not used
plugins/hciops.c:125: error: unused variable ‘di’

Always check that your patch compiles cleanly with ./bootstrap-configure
before submitting upstream.

Johan

  reply	other threads:[~2010-08-09 21:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09 21:07 [PATCH 0/2] Use HCI device type to determine suitability of HCI commands David Scherba
2010-08-09 21:07 ` [PATCH 1/2] Remove non-functional hci_devinfo calls in init_device() David Scherba
2010-08-09 21:51   ` Johan Hedberg [this message]
2010-08-10 15:12     ` David Scherba
2010-08-09 21:07 ` [PATCH 2/2] Use HCI device type to gate BR/EDR-specific HCI commands David Scherba
2010-08-09 21:59   ` Johan Hedberg
  -- strict thread matches above, loose matches on Subject: below --
2010-08-10 15:15 [PATCH v2 0/2] Use HCI device type to determine suitability of " David Scherba
2010-08-10 15:15 ` [PATCH 1/2] Remove non-functional hci_devinfo calls in init_device() David Scherba
2010-08-10 19:20   ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100809215149.GA25488@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=dscherba@codeaurora.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=rshaffer@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox