From: Johan Hedberg <johan.hedberg@gmail.com>
To: David Scherba <dscherba@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
rshaffer@codeaurora.org
Subject: Re: [PATCH 2/2] Use HCI device type to gate BR/EDR-specific HCI commands
Date: Tue, 10 Aug 2010 15:16:16 -0400 [thread overview]
Message-ID: <20100810191616.GA26091@jh-x301> (raw)
In-Reply-To: <1281455145-1777-1-git-send-email-dscherba@codeaurora.org>
Hi David,
On Tue, Aug 10, 2010, David Scherba wrote:
> --- a/lib/hci_lib.h
> +++ b/lib/hci_lib.h
> @@ -169,6 +169,11 @@ static inline int hci_test_bit(int nr, void *addr)
> return *((uint32_t *) addr + (nr >> 5)) & (1 << (nr & 31));
> }
>
> +static inline int ignore_device(struct hci_dev_info *di)
> +{
> + return hci_test_bit(HCI_RAW, &di->flags) || di->type >> 4 != HCI_BREDR;
> +}
Since this is hci_lib.h (something I didn't realize in the previous
review) the function should follow the same namespace as all other
functions in the header file, i.e. hci_*. However, does the function
really need to be exported in this public library header file, i.e.
isn't there some private header file that could be used instead?
Johan
next prev parent reply other threads:[~2010-08-10 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 15:15 [PATCH v2 0/2] Use HCI device type to determine suitability of HCI commands David Scherba
2010-08-10 15:15 ` [PATCH 1/2] Remove non-functional hci_devinfo calls in init_device() David Scherba
2010-08-10 19:20 ` Johan Hedberg
2010-08-10 15:15 ` [PATCH 2/2] Use HCI device type to gate BR/EDR-specific HCI commands David Scherba
2010-08-10 15:44 ` David Scherba
2010-08-10 15:45 ` David Scherba
2010-08-10 19:16 ` Johan Hedberg [this message]
2010-08-10 19:49 ` David Scherba
2010-08-10 19:51 ` [PATCH 1/1] " David Scherba
2010-08-10 20:15 ` Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2010-08-09 21:07 [PATCH 0/2] Use HCI device type to determine suitability of " David Scherba
2010-08-09 21:07 ` [PATCH 2/2] Use HCI device type to gate BR/EDR-specific " David Scherba
2010-08-09 21:59 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810191616.GA26091@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=dscherba@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=rshaffer@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox