From: Marcel Mol <marcel@mesa.nl>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] ebook backend: separate concatenated vcards with \r\n.
Date: Thu, 12 Aug 2010 12:20:46 +0200 [thread overview]
Message-ID: <201008121026.o7CAQDVU005280@joshua.mesa.nl> (raw)
The END:VCARD is not ended with \r\n for single vcards.
In a phonebook pull request vcards are concatenated as one
big blob. Carkits seem to choke on the fact that an END:VCARD
is directly followed by BEGIN:VCARD without \r\n separation.
(as observed by many n900 users).
---
plugins/phonebook-ebook.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/plugins/phonebook-ebook.c b/plugins/phonebook-ebook.c
index ad40be3..da68ac0 100644
--- a/plugins/phonebook-ebook.c
+++ b/plugins/phonebook-ebook.c
@@ -175,8 +175,11 @@ static void ebookpull_cb(EBook *book, EBookStatus estatus, GList *contacts,
data->params->filter);
string = g_string_append(string, vcard);
+ string = g_string_append(string, "\r\n");
g_free(vcard);
}
+ DBG("collected %d vcards", count);
+
done:
data->cb(string->str, string->len, count, 0, data->user_data);
--
1.7.2
next reply other threads:[~2010-08-12 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 10:20 Marcel Mol [this message]
2010-08-12 11:15 ` [PATCH] ebook backend: separate concatenated vcards with \r\n Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008121026.o7CAQDVU005280@joshua.mesa.nl \
--to=marcel@mesa.nl \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox