From: Johan Hedberg <johan.hedberg@nokia.com>
To: Dmitriy Paliy <dmitriy.paliy@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/5] Add fast connectable to hciops
Date: Tue, 17 Aug 2010 17:41:32 +0300 [thread overview]
Message-ID: <20100817144132.GA22079@jh-x301> (raw)
In-Reply-To: <1282053934-19445-3-git-send-email-dmitriy.paliy@nokia.com>
Hi Dmitry,
On Tue, Aug 17, 2010, Dmitriy Paliy wrote:
> + if ( hci_send_cmd(dd, OGF_HOST_CTL, OCF_WRITE_PAGE_ACTIVITY,
> + WRITE_PAGE_ACTIVITY_CP_SIZE, &cp) < 0 ) {
> + err = -errno;
> + } else if ( hci_send_cmd(dd, OGF_HOST_CTL, OCF_WRITE_PAGE_SCAN_TYPE,
> + 1, &type) < 0 ) {
> + err = -errno;
> + }
A few coding style issues: no braces for one-line if-statements and
remove the spaces after ( and before ) should be removed.
Johan
next prev parent reply other threads:[~2010-08-17 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 14:05 [PATCH 0/5] Fast connectable mode for HFP Dmitriy Paliy
2010-08-17 14:05 ` [PATCH 1/5] Add STANDARD and INTERLACED page scan definitions Dmitriy Paliy
2010-08-17 14:05 ` [PATCH 2/5] Add fast connectable to hciops Dmitriy Paliy
2010-08-17 14:41 ` Johan Hedberg [this message]
2010-08-17 14:05 ` [PATCH 3/5] Add set fast connectable to adapter Dmitriy Paliy
2010-08-17 14:05 ` [PATCH 4/5] Add set fast connectable to audio manager Dmitriy Paliy
2010-08-17 14:43 ` Johan Hedberg
2010-08-17 14:05 ` [PATCH 5/5] Add fast connectable support to HFP Dmitriy Paliy
2010-08-17 14:20 ` [PATCH 0/5] Fast connectable mode for HFP Johan Hedberg
-- strict thread matches above, loose matches on Subject: below --
2010-08-18 10:35 [PATCH 0/5] Fast connectable mode for HFP (update) Dmitriy Paliy
2010-08-18 10:35 ` [PATCH 2/5] Add fast connectable to hciops Dmitriy Paliy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817144132.GA22079@jh-x301 \
--to=johan.hedberg@nokia.com \
--cc=dmitriy.paliy@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox