From: Colin Didier <didier@archos.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] An interrupted syscall is not an error when returning from poll() in audio/pcm_bluetooth.c
Date: Wed, 25 Aug 2010 10:54:54 +0200 [thread overview]
Message-ID: <20100825085454.GB27072@cybione.org> (raw)
Hello,
An interrupted syscall is not an error when returning from poll() at
line 240 of audio/pcm_bluetooth.c. So no need to freak out.
Here is a patch to fix this.
Cheers,
Colin DIDIER
--- a/audio/pcm_bluetooth.c 2010-08-25 10:08:37.000000000 +0200
+++ b/audio/pcm_bluetooth.c 2010-08-25 10:08:59.000000000 +0200
@@ -237,9 +237,11 @@
ret = poll(fds, 2, poll_timeout);
if (ret < 0) {
- SNDERR("poll error: %s (%d)", strerror(errno), errno);
- if (errno != EINTR)
+ if (errno != EINTR) {
+ SNDERR("poll error: %s (%d)", strerror(errno),
+ errno);
break;
+ }
} else if (ret > 0) {
ret = (fds[0].revents) ? 0 : 1;
SNDERR("poll fd %d revents %d", ret, fds[ret].revents);
next reply other threads:[~2010-08-25 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 8:54 Colin Didier [this message]
2010-08-25 11:28 ` [PATCH] An interrupted syscall is not an error when returning from poll() in audio/pcm_bluetooth.c Johan Hedberg
2010-08-25 13:07 ` [PATCH] No error message on interrupted syscall Colin Didier
2010-08-25 13:29 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825085454.GB27072@cybione.org \
--to=didier@archos.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox