Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: "Daniel Örstadius" <daniel.orstadius@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Store new local name before writing it to HCI
Date: Fri, 3 Sep 2010 10:58:17 +0300	[thread overview]
Message-ID: <20100903075817.GA1917@jh-x301> (raw)
In-Reply-To: <AANLkTi=avFuiQjApV=Wm01KjVL4LmwJFQb6=iJostpGW@mail.gmail.com>

Hi Daniel,

On Fri, Sep 03, 2010, Daniel Örstadius wrote:
> From: Daniel Orstadius <daniel.orstadius@nokia.com>
> Date: Mon, 30 Aug 2010 16:54:09 +0300
> Subject: [PATCH] Store new local name before writing it to adapter
> 
> Store new local name to the file system and emit property changed
> before actually writing the name to the adapter.
> 
> The reason for the patch is the scenario were an application sets
> the name and then immediately turns off the adapter. Previously the
> requested name change might not have been properly applied in that
> case. The new name was not written to storage until it had been
> read from the adapter and the adapter could have been turned off
> before the read command was completed.
> 
> Avoids writing the name twice by using a boolean variable in the
> btd_adapter struct. The name may be changed by using for example
> hciconfig and in that case the name needs to be updated to storage
> after reading.
> ---
>  src/adapter.c |   35 ++++++++++++++++++++++-------------
>  1 files changed, 22 insertions(+), 13 deletions(-)

Thanks for the patch. It's now in the upstream tree.

Johan

      reply	other threads:[~2010-09-03  7:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30 14:35 [PATCH] Store new local name before writing it to HCI Daniel Örstadius
2010-09-03  7:37 ` Daniel Örstadius
2010-09-03  7:58   ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100903075817.GA1917@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=daniel.orstadius@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox