From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: "Gustavo F. Padovan" <gustavo@padovan.org>,
linux-bluetooth@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH bluetooth-next-2.6 2/2] Bluetooth: Initial move of L2CAP socket to l2cap_sock.c
Date: Sat, 4 Sep 2010 19:18:18 -0300 [thread overview]
Message-ID: <20100904221818.GA9795@vigoh> (raw)
In-Reply-To: <AANLkTinHsLbqaoFh_XXceb-aY0weOoDrRcbU1QLi3dfU@mail.gmail.com>
* Anderson Lizardo <anderson.lizardo@openbossa.org> [2010-09-04 09:14:56 -0=
400]:
> On Sat, Sep 4, 2010 at 5:18 AM, Gustavo F. Padovan <gustavo@padovan.org> =
wrote:
> > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> > index f2062aa..1f6d448 100644
> > --- a/net/bluetooth/l2cap_core.c
> > +++ b/net/bluetooth/l2cap_core.c
> > @@ -57,24 +57,21 @@
> >
> > =A0#define VERSION "2.15"
> >
> > -static int disable_ertm =3D 0;
> > +int disable_ertm =3D 0;
> >
> > =A0static u32 l2cap_feat_mask =3D L2CAP_FEAT_FIXED_CHAN;
> > =A0static u8 l2cap_fixed_chan[8] =3D { 0x02, };
> >
> > -static const struct proto_ops l2cap_sock_ops;
> > -
> > =A0static struct workqueue_struct *_busy_wq;
> >
> > -static struct bt_sock_list l2cap_sk_list =3D {
> > +struct bt_sock_list l2cap_sk_list =3D {
> > =A0 =A0 =A0 =A0.lock =3D __RW_LOCK_UNLOCKED(l2cap_sk_list.lock)
> > =A0};
> >
> > =A0static void l2cap_busy_work(struct work_struct *work);
> >
> > -static void __l2cap_sock_close(struct sock *sk, int reason);
> > =A0static void l2cap_sock_close(struct sock *sk);
> > -static void l2cap_sock_kill(struct sock *sk);
> > +void l2cap_sock_kill(struct sock *sk);
>=20
> If l2cap_core.c includes net/bluetooth/l2cap.h, you don't need the
> declaration above.
Yes, you are right. Thanks for the review.
--=20
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
next prev parent reply other threads:[~2010-09-04 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-04 9:18 [PATCH bluetooth-next-2.6 1/2] Bluetooth: Rename l2cap.c to l2cap_core.c Gustavo F. Padovan
2010-09-04 9:18 ` [PATCH bluetooth-next-2.6 2/2] Bluetooth: Initial move of L2CAP socket to l2cap_sock.c Gustavo F. Padovan
2010-09-04 13:14 ` Anderson Lizardo
2010-09-04 22:18 ` Gustavo F. Padovan [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-05 4:58 [PATCH bluetooth-next-2.6 1/2] Bluetooth: Rename l2cap.c to l2cap_core.c Gustavo F. Padovan
2010-09-05 4:58 ` [PATCH bluetooth-next-2.6 2/2] Bluetooth: Initial move of L2CAP socket to l2cap_sock.c Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100904221818.GA9795@vigoh \
--to=padovan@profusion.mobi \
--cc=anderson.lizardo@openbossa.org \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).