From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: Add new plugin to set adapter class
Date: Mon, 6 Sep 2010 14:15:16 +0300 [thread overview]
Message-ID: <20100906111516.GA23167@jh-x301> (raw)
In-Reply-To: <1283770089.7529.9.camel@localhost.localdomain>
Hi Bastien,
On Mon, Sep 06, 2010, Bastien Nocera wrote:
> +if HAL
> builtin_modules += hal
> builtin_sources += plugins/hal.c
> +else
> +builtin_modules += formfactor
> +builtin_sources += plugins/formfactor.c
> +endif
Previously it was possible to --disable-hal and be sure that whatever is
defined in main.conf gets used (this is e.g. something that has been
important for us in Maemo/MeeGo). Your patch seems to make one of the
two automated adapter class sources always be used and so potentially
overriding what main.conf says. So I'd prefer to keep the possibility of
disably any such plugins completely.
Johan
next prev parent reply other threads:[~2010-09-06 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 10:48 Add new plugin to set adapter class Bastien Nocera
2010-09-06 11:15 ` Johan Hedberg [this message]
2010-09-06 11:17 ` Bastien Nocera
2010-09-06 11:30 ` Johan Hedberg
2010-09-06 12:05 ` Bastien Nocera
2010-09-06 13:13 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906111516.GA23167@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox