* [PATCH] Fix clean-local target
@ 2010-09-03 11:33 Waldemar Rymarkiewicz
2010-09-03 12:13 ` Luiz Augusto von Dentz
2010-09-03 19:19 ` Uwe Kleine-König
0 siblings, 2 replies; 6+ messages in thread
From: Waldemar Rymarkiewicz @ 2010-09-03 11:33 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Waldemar Rymarkiewicz
The fix avoids failure of the second consequent call of 'make clean'.
Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
---
Makefile.am | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 5684e99..2fa03e1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
$(AM_V_at)$(MKDIR_P) lib/bluetooth
$(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
-clean-local: lib/bluetooth
- @$(RM) -r $<
+clean-local:
+ $(RM) -r lib/bluetooth
\ No newline at end of file
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix clean-local target
2010-09-03 11:33 [PATCH] Fix clean-local target Waldemar Rymarkiewicz
@ 2010-09-03 12:13 ` Luiz Augusto von Dentz
2010-09-03 12:21 ` Waldemar.Rymarkiewicz
2010-09-03 19:19 ` Uwe Kleine-König
1 sibling, 1 reply; 6+ messages in thread
From: Luiz Augusto von Dentz @ 2010-09-03 12:13 UTC (permalink / raw)
To: Waldemar Rymarkiewicz; +Cc: linux-bluetooth
Hi,
On Fri, Sep 3, 2010 at 2:33 PM, Waldemar Rymarkiewicz
<waldemar.rymarkiewicz@tieto.com> wrote:
> The fix avoids failure of the second consequent call of 'make clean'.
>
> Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
> ---
> Makefile.am | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 5684e99..2fa03e1 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
> $(AM_V_at)$(MKDIR_P) lib/bluetooth
> $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>
> -clean-local: lib/bluetooth
> - @$(RM) -r $<
> +clean-local:
> + $(RM) -r lib/bluetooth
> \ No newline at end of file
> --
> 1.7.0.4
Could you please remove the Signed-off-by, we don't use it on userspace.
--
Luiz Augusto von Dentz
Computer Engineer
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Fix clean-local target
2010-09-03 12:13 ` Luiz Augusto von Dentz
@ 2010-09-03 12:21 ` Waldemar.Rymarkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Waldemar.Rymarkiewicz @ 2010-09-03 12:21 UTC (permalink / raw)
To: luiz.dentz; +Cc: linux-bluetooth
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
Removed.
Thanks,
/Waldek
>-----Original Message-----
>From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
>Sent: Friday, September 03, 2010 2:13 PM
>To: Rymarkiewicz Waldemar
>Cc: linux-bluetooth@vger.kernel.org
>Subject: Re: [PATCH] Fix clean-local target
>
>Hi,
>
>On Fri, Sep 3, 2010 at 2:33 PM, Waldemar Rymarkiewicz
><waldemar.rymarkiewicz@tieto.com> wrote:
>> The fix avoids failure of the second consequent call of 'make clean'.
>>
>> Signed-off-by: Waldemar Rymarkiewicz
><waldemar.rymarkiewicz@tieto.com>
>> ---
>> Makefile.am | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am index 5684e99..2fa03e1 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
>> $(AM_V_at)$(MKDIR_P) lib/bluetooth
>> $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>>
>> -clean-local: lib/bluetooth
>> - @$(RM) -r $<
>> +clean-local:
>> + $(RM) -r lib/bluetooth
>> \ No newline at end of file
>> --
>> 1.7.0.4
>
>Could you please remove the Signed-off-by, we don't use it on
>userspace.
>
>--
>Luiz Augusto von Dentz
>Computer Engineer
>
[-- Attachment #2: 0001-Fix-clean-local-target.patch --]
[-- Type: application/octet-stream, Size: 720 bytes --]
From e3342962eff3f442bd4d349ad74eb8a91e30d384 Mon Sep 17 00:00:00 2001
From: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
Date: Fri, 3 Sep 2010 13:20:08 +0200
Subject: [PATCH] Fix clean-local target
The fix avoids failure of the second consequent call of 'make clean'.
---
Makefile.am | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 5684e99..2fa03e1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
$(AM_V_at)$(MKDIR_P) lib/bluetooth
$(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
-clean-local: lib/bluetooth
- @$(RM) -r $<
+clean-local:
+ $(RM) -r lib/bluetooth
\ No newline at end of file
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix clean-local target
2010-09-03 11:33 [PATCH] Fix clean-local target Waldemar Rymarkiewicz
2010-09-03 12:13 ` Luiz Augusto von Dentz
@ 2010-09-03 19:19 ` Uwe Kleine-König
2010-09-07 9:09 ` Waldemar.Rymarkiewicz
1 sibling, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2010-09-03 19:19 UTC (permalink / raw)
To: Waldemar Rymarkiewicz; +Cc: linux-bluetooth
Hello Waldemar,
On Fri, Sep 03, 2010 at 01:33:33PM +0200, Waldemar Rymarkiewicz wrote:
> The fix avoids failure of the second consequent call of 'make clean'.
>
> Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
> ---
> Makefile.am | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 5684e99..2fa03e1 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
> $(AM_V_at)$(MKDIR_P) lib/bluetooth
> $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>
> -clean-local: lib/bluetooth
> - @$(RM) -r $<
> +clean-local:
> + $(RM) -r lib/bluetooth
> \ No newline at end of file
Is the missing newline at eof on purpose?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Fix clean-local target
2010-09-03 19:19 ` Uwe Kleine-König
@ 2010-09-07 9:09 ` Waldemar.Rymarkiewicz
2010-09-07 9:47 ` Johan Hedberg
0 siblings, 1 reply; 6+ messages in thread
From: Waldemar.Rymarkiewicz @ 2010-09-07 9:09 UTC (permalink / raw)
To: u.kleine-koenig, johan.hedberg; +Cc: linux-bluetooth
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]
Uwe,
There is no intention behind that. Have updated the patch.
@Johan: Will you consider to push it to upstream ?
/Waldek
>-----Original Message-----
>From: Uwe Kleine-König [mailto:u.kleine-koenig@pengutronix.de]
>Sent: Friday, September 03, 2010 9:20 PM
>To: Rymarkiewicz Waldemar
>Cc: linux-bluetooth@vger.kernel.org
>Subject: Re: [PATCH] Fix clean-local target
>
>Hello Waldemar,
>
>On Fri, Sep 03, 2010 at 01:33:33PM +0200, Waldemar Rymarkiewicz wrote:
>> The fix avoids failure of the second consequent call of 'make clean'.
>>
>> Signed-off-by: Waldemar Rymarkiewicz
><waldemar.rymarkiewicz@tieto.com>
>> ---
>> Makefile.am | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am index 5684e99..2fa03e1 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
>> $(AM_V_at)$(MKDIR_P) lib/bluetooth
>> $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>>
>> -clean-local: lib/bluetooth
>> - @$(RM) -r $<
>> +clean-local:
>> + $(RM) -r lib/bluetooth
>> \ No newline at end of file
>Is the missing newline at eof on purpose?
>
>Best regards
>Uwe
>
>--
>Pengutronix e.K. | Uwe Kleine-König
> |
>Industrial Linux Solutions |
>http://www.pengutronix.de/ |
>
[-- Attachment #2: 0001-Fix-clean-local-target.patch --]
[-- Type: application/octet-stream, Size: 695 bytes --]
From 56b93956070d45e3f70ba0579a44d757a3ba994b Mon Sep 17 00:00:00 2001
From: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
Date: Fri, 3 Sep 2010 13:20:08 +0200
Subject: [PATCH] Fix clean-local target
The fix avoids failure of the second consequent call of 'make clean'.
---
Makefile.am | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 9a78780..49815af 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -403,5 +403,6 @@ lib/bluetooth/%.h: lib/%.h
$(AM_V_at)$(MKDIR_P) lib/bluetooth
$(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
-clean-local: lib/bluetooth
- @$(RM) -r $<
+clean-local:
+ $(RM) -r lib/bluetooth
+
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix clean-local target
2010-09-07 9:09 ` Waldemar.Rymarkiewicz
@ 2010-09-07 9:47 ` Johan Hedberg
0 siblings, 0 replies; 6+ messages in thread
From: Johan Hedberg @ 2010-09-07 9:47 UTC (permalink / raw)
To: Waldemar.Rymarkiewicz; +Cc: u.kleine-koenig, linux-bluetooth
Hi Waldek,
On Tue, Sep 07, 2010, Waldemar.Rymarkiewicz@tieto.com wrote:
> @Johan: Will you consider to push it to upstream ?
Yes, it's now upstream. I was waiting for a comment from Marcel since he
quite often has something to say about autotools file changes, but since
the patch seems quite trivial I went ahead and pushed it.
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-07 9:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 11:33 [PATCH] Fix clean-local target Waldemar Rymarkiewicz
2010-09-03 12:13 ` Luiz Augusto von Dentz
2010-09-03 12:21 ` Waldemar.Rymarkiewicz
2010-09-03 19:19 ` Uwe Kleine-König
2010-09-07 9:09 ` Waldemar.Rymarkiewicz
2010-09-07 9:47 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).