From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
gustavo@padovan.org, rshaffer@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 4/4] Bluetooth: Use a stream-oriented recvmsg with SOCK_STREAM L2CAP sockets.
Date: Wed, 8 Sep 2010 16:47:45 -0300 [thread overview]
Message-ID: <20100908194745.GL16973@vigoh> (raw)
In-Reply-To: <1283965529-17068-5-git-send-email-mathewm@codeaurora.org>
* Mat Martineau <mathewm@codeaurora.org> [2010-09-08 10:05:29 -0700]:
> L2CAP ERTM sockets can be opened with the SOCK_STREAM socket type,
> which is a mandatory request for ERTM mode.
>
> However, these sockets still have SOCK_SEQPACKET read semantics when
> bt_sock_recvmsg() is used to pull data from the receive queue. If the
> application is only reading part of a frame, then the unread portion
> of the frame is discarded. If the application requests more bytes
> than are in the current frame, only the current frame's data is
> returned.
>
> This patch utilizes common code derived from RFCOMM's recvmsg()
> function to make L2CAP SOCK_STREAM reads behave like RFCOMM reads (and
> other SOCK_STREAM sockets in general). The application may read one
> byte at a time from the input stream and not lose any data, and may
> also read across L2CAP frame boundaries.
>
> Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
> ---
> net/bluetooth/l2cap.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
next prev parent reply other threads:[~2010-09-08 19:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 17:05 [PATCH 0/4 v6] L2CAP updates for valid PSMs, SOCK_STREAM reads Mat Martineau
2010-09-08 17:05 ` [PATCH 1/4] Bluetooth: Validate PSM values in calls to connect() and bind() Mat Martineau
2010-09-08 19:45 ` Gustavo F. Padovan
2010-09-08 17:05 ` [PATCH 2/4] Bluetooth: Add common code for stream-oriented recvmsg() Mat Martineau
2010-09-08 19:46 ` Gustavo F. Padovan
2010-09-08 17:05 ` [PATCH 3/4] Bluetooth: Use common SOCK_STREAM receive code in RFCOMM Mat Martineau
2010-09-08 19:47 ` Gustavo F. Padovan
2010-09-08 17:05 ` [PATCH 4/4] Bluetooth: Use a stream-oriented recvmsg with SOCK_STREAM L2CAP sockets Mat Martineau
2010-09-08 19:47 ` Gustavo F. Padovan [this message]
2010-09-20 21:14 ` [PATCH 0/4 v6] L2CAP updates for valid PSMs, SOCK_STREAM reads Ron Shaffer
2010-09-27 20:38 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908194745.GL16973@vigoh \
--to=padovan@profusion.mobi \
--cc=gustavo@padovan.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mathewm@codeaurora.org \
--cc=rshaffer@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).