From: Johan Hedberg <johan.hedberg@gmail.com>
To: Zhenhua Zhang <zhenhua.zhang@intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/4] btio: Remove unused bt_io_set function
Date: Thu, 9 Sep 2010 13:38:42 +0300 [thread overview]
Message-ID: <20100909101901.GA16324@jh-x301> (raw)
In-Reply-To: <1284025283-3773-4-git-send-email-zhenhua.zhang@intel.com>
Hi,
On Thu, Sep 09, 2010, Zhenhua Zhang wrote:
> It is not used by either obex or bluez.
> ---
> btio/btio.c | 33 ---------------------------------
> btio/btio.h | 3 ---
> 2 files changed, 0 insertions(+), 36 deletions(-)
I don't think removing this feature is a good idea. Even though there
aren't any current users of bt_io_set doesn't mean that there wont be in
the future. I remember e.g. discussions regarding AMP about applications
needing the ability to request a switch from BR/EDR to WLAN for an
active connection. This could e.g. be accomplished through a setsockopt
call. Other uses for setsockopt while a connection is open, or even
changing settings for an existing server socket might exist too.
Johan
next prev parent reply other threads:[~2010-09-09 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 9:41 obex: isolate btio.[ch] as a library and do some cleanup Zhenhua Zhang
2010-09-09 9:41 ` [PATCH 1/4] btio: Remove blank line at EOF Zhenhua Zhang
2010-09-09 9:41 ` [PATCH 2/4] btio: Seperate btio.[ch] into btio directory Zhenhua Zhang
2010-09-09 9:41 ` [PATCH 3/4] btio: Remove unused bt_io_set function Zhenhua Zhang
2010-09-09 10:38 ` Johan Hedberg [this message]
2010-09-10 0:11 ` Zhang, Zhenhua
2010-09-09 9:41 ` [PATCH 4/4] btio: Replace void * with gpointer Zhenhua Zhang
-- strict thread matches above, loose matches on Subject: below --
2010-09-09 9:43 bluez: isolate btio.[ch] as a library and do cleanup Zhenhua Zhang
2010-09-09 9:43 ` [PATCH 3/4] btio: Remove unused bt_io_set function Zhenhua Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909101901.GA16324@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=zhenhua.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox