linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: "Gustavo F. Padovan" <padovan@profusion.mobi>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	marcel@holtmann.org, davem@davemloft.net,
	linux-bluetooth@vger.kernel.org
Subject: Re: Possible regression with skb_clone() in 2.6.36
Date: Fri, 10 Sep 2010 10:15:33 +0000	[thread overview]
Message-ID: <20100910101533.GA21844@ff.dom.local> (raw)
In-Reply-To: <1283988727-1456-1-git-send-email-padovan@profusion.mobi>

On 2010-09-09 01:32, Gustavo F. Padovan wrote:
> I've been experiencing some problems when running the L2CAP Streaming mode in
> 2.6.36. The system quickly runs in an Out Of Memory condition and crash. That
> wasn't happening before, so I think we may have a regression here (I didn't
> find where yet). The crash log is below.
> 
> The following patch does not fix the regression, but shows that removing the
> skb_clone() call from l2cap_streaming_send() we workaround the problem. The
> patch is good anyway because it saves memory and time.
> 
> By now I have no idea on how to fix this.

My suggestion is to check the length of conn->data_q in hci_send_acl()
while this happens, and maybe try to set some limit here.

Jarek P.

  parent reply	other threads:[~2010-09-10 10:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 23:32 Possible regression with skb_clone() in 2.6.36 Gustavo F. Padovan
2010-09-08 23:32 ` [PATCH] Bluetooth: Simplify L2CAP Streaming mode sending Gustavo F. Padovan
2010-09-10 10:15 ` Jarek Poplawski [this message]
2010-09-10 16:53 ` Possible regression with skb_clone() in 2.6.36 Mat Martineau
2010-09-10 19:45   ` Gustavo F. Padovan
2010-09-15 18:42     ` Gustavo F. Padovan
2010-09-16  0:10     ` Gustavo F. Padovan
2010-09-16 16:40       ` Mat Martineau
2010-09-17 21:08         ` Gustavo F. Padovan
  -- strict thread matches above, loose matches on Subject: below --
2010-08-30 23:10 Gustavo F. Padovan
2010-09-17 22:34 ` Andrew Morton
2010-09-21  4:10   ` Gustavo F. Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100910101533.GA21844@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).