linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Suraj Sumangala <suraj@atheros.com>
Cc: linux-bluetooth@vger.kernel.org, Jothikumar.Mothilal@Atheros.com
Subject: Re: [RFC] BlueZ D-Bus Sim Access Profile Server API description
Date: Mon, 13 Sep 2010 13:59:32 +0300	[thread overview]
Message-ID: <20100913105932.GA3566@jh-x301> (raw)
In-Reply-To: <1284374584-12282-1-git-send-email-suraj@atheros.com>

Hi Suraj,

On Mon, Sep 13, 2010, Suraj Sumangala wrote:
> +		void Response(string command, string result, object response)

This method should be removed. Instead, you should use the methor return
messages for the commands to relay the response information.

> +Sim Access Server Agent hierarchy
> +=================================
> +
> +Service         unique name
> +Interface       org.bluez.SAPServerAgent
> +Object path     freely definable
> +
> +Methods		Request(string command, object param)

Since the set of SAP commands is fixed and rather short it'd be much
simpler if you have a separate D-Bus method for each command
(particularly from the method and method return signature perspective).
You also seem to have some confusion about what an "object" type
parameter is. It seems you're using it for some sort of variant type
when it will only ever represent a simple object path.

Johan

  reply	other threads:[~2010-09-13 10:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 10:43 [RFC] BlueZ D-Bus Sim Access Profile Server API description Suraj Sumangala
2010-09-13 10:59 ` Johan Hedberg [this message]
2010-09-13 11:31   ` Suraj Sumangala
2010-09-13 13:20     ` Johan Hedberg
2010-09-13 15:18       ` Suraj Sumangala
2010-09-13 16:47         ` Johan Hedberg
2010-09-14  5:00           ` Suraj Sumangala
2010-09-13 12:11 ` Waldemar.Rymarkiewicz
2010-09-13 12:29   ` Suraj Sumangala
2010-09-13 12:47     ` Waldemar.Rymarkiewicz
2010-09-13 15:25       ` Suraj Sumangala
2010-09-14  5:42 ` Marcel Holtmann
2010-09-14  6:28   ` Suraj Sumangala
2010-09-15  3:44     ` Marcel Holtmann
2010-09-15  6:14       ` Suraj Sumangala
2010-09-15  7:32         ` Nicolas GUILBAUD
2010-09-15  8:24           ` Suraj Sumangala
2010-09-15  8:56             ` Nicolas GUILBAUD
2010-09-16 23:00           ` Marcel Holtmann
2010-09-17 11:01             ` Nicolas GUILBAUD
2010-09-18  0:16               ` Marcel Holtmann
2010-09-15  9:18       ` Waldemar.Rymarkiewicz
2010-09-16  7:50         ` Suraj Sumangala
2010-09-16 23:04         ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100913105932.GA3566@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=Jothikumar.Mothilal@Atheros.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=suraj@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).