* [PATCH] Fix crash on gstreamer plugin if device doesn't support sbc
@ 2010-09-13 12:40 Luiz Augusto von Dentz
2010-09-13 13:21 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2010-09-13 12:40 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.dentz-von@nokia.com>
---
audio/gstavdtpsink.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/audio/gstavdtpsink.c b/audio/gstavdtpsink.c
index f0e5b76..b8c8832 100644
--- a/audio/gstavdtpsink.c
+++ b/audio/gstavdtpsink.c
@@ -448,6 +448,9 @@ static GstStructure *gst_avdtp_sink_parse_sbc_caps(
GValue *list;
gboolean mono, stereo;
+ if (sbc == NULL)
+ return NULL;
+
structure = gst_structure_empty_new("audio/x-sbc");
value = g_value_init(g_new0(GValue, 1), G_TYPE_STRING);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Fix crash on gstreamer plugin if device doesn't support sbc
2010-09-13 12:40 [PATCH] Fix crash on gstreamer plugin if device doesn't support sbc Luiz Augusto von Dentz
@ 2010-09-13 13:21 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2010-09-13 13:21 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hi Luiz,
On Mon, Sep 13, 2010, Luiz Augusto von Dentz wrote:
> audio/gstavdtpsink.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/audio/gstavdtpsink.c b/audio/gstavdtpsink.c
> index f0e5b76..b8c8832 100644
> --- a/audio/gstavdtpsink.c
> +++ b/audio/gstavdtpsink.c
> @@ -448,6 +448,9 @@ static GstStructure *gst_avdtp_sink_parse_sbc_caps(
> GValue *list;
> gboolean mono, stereo;
>
> + if (sbc == NULL)
> + return NULL;
> +
> structure = gst_structure_empty_new("audio/x-sbc");
> value = g_value_init(g_new0(GValue, 1), G_TYPE_STRING);
>
The patch has been pushed upstream. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-13 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-13 12:40 [PATCH] Fix crash on gstreamer plugin if device doesn't support sbc Luiz Augusto von Dentz
2010-09-13 13:21 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).