From: Oliver Neukum <oneukum@suse.de>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
linux-bluetooth@vger.kernel.org, linux-usb@vger.kernel.org,
marcel@holtmann.org
Subject: Re: [PATCH 2/3] bluetooth: Remove some unnecessary error messages
Date: Fri, 17 Sep 2010 10:59:06 +0200 [thread overview]
Message-ID: <201009171059.06486.oneukum@suse.de> (raw)
In-Reply-To: <AANLkTi=NBrb70ZvafQxZMnLZZcmuGEPeon4Vqq4vkpce@mail.gmail.com>
Am Freitag, 17. September 2010, 10:33:30 schrieb Andrei Emeltchenko:
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index d22ce3c..3ace025 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -229,11 +229,8 @@ static void btusb_intr_complete(struct urb *urb)
> > usb_anchor_urb(urb, &data->intr_anchor);
> >
> > err = usb_submit_urb(urb, GFP_ATOMIC);
> > - if (err < 0) {
> > - BT_ERR("%s urb %p failed to resubmit (%d)",
> > - hdev->name, urb, -err);
> > + if (err < 0)
> > usb_unanchor_urb(urb);
> > - }
> > }
> >
>
> I do not get the point here. Cannot you just undef BT_ERR if you
> enabled debug? I believe this is standard behavior.
You can undefine BT_ERR, but then you'll miss error reports.
This message may indicate an error, but usually doesn't if
you use runtime pm.
Regards
Oliver
next prev parent reply other threads:[~2010-09-17 8:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 17:58 [PATCH 1/3] bluetooth: Take a runtime pm reference on hid connections Matthew Garrett
2010-09-16 17:58 ` [PATCH 2/3] bluetooth: Remove some unnecessary error messages Matthew Garrett
2010-09-17 8:33 ` Andrei Emeltchenko
2010-09-17 8:59 ` Oliver Neukum [this message]
2010-10-18 11:55 ` Marcel Holtmann
2010-10-19 16:01 ` Matthew Garrett
2010-09-16 17:58 ` [PATCH 3/3] bluetooth: Enable USB autosuspend by default on btusb Matthew Garrett
2010-10-13 10:00 ` Marcel Holtmann
2010-10-18 6:06 ` Gustavo F. Padovan
2010-09-17 8:39 ` [PATCH 1/3] bluetooth: Take a runtime pm reference on hid connections Oliver Neukum
2010-09-17 12:24 ` Matthew Garrett
2010-10-13 9:32 ` Marcel Holtmann
2010-10-19 16:03 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009171059.06486.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).