From: Johan Hedberg <johan.hedberg@gmail.com>
To: Santiago Carot-Nemesio <sancane@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Simplify logic to calculate the BT/system clock latency
Date: Wed, 22 Sep 2010 10:59:28 +0300 [thread overview]
Message-ID: <20100922075928.GA17298@jh-x301> (raw)
In-Reply-To: <1285139031-1570-1-git-send-email-sancane@gmail.com>
Hi,
On Wed, Sep 22, 2010, Santiago Carot-Nemesio wrote:
> This is only a cosmetic change. Using a while loop
> we avoid direct manipulation of counter loop variable
> when error happens reading the BT clock.
> ---
> health/mcap_sync.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
Thanks. The patch has been pushed upstream.
> + while ((i < 20) && (retries > 0)) {
The extra parentheses around the comparisons are unnecessary. I fixed
that in a subsequent cleanup commit. Usually we only add these extra
parentheses for binary bitwise operations such as & and | for clarity.
Johan
prev parent reply other threads:[~2010-09-22 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 7:03 [PATCH 1/2] Simplify logic to calculate the BT/system clock latency Santiago Carot-Nemesio
2010-09-22 7:03 ` [PATCH 2/2] Remove magic numbers in MCAP CSP Santiago Carot-Nemesio
2010-09-22 7:59 ` Johan Hedberg
2010-09-22 7:59 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922075928.GA17298@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).