From: Ville Tervo <ville.tervo@nokia.com>
To: ext haijun liu <liuhaijun.er@gmail.com>
Cc: "Gustavo F. Padovan" <padovan@profusion.mobi>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
Mat Martineau <mathewm@codeaurora.org>,
"dantian.ip" <dantian.ip@gmail.com>
Subject: Re: [PATCH] Bluetooth: Replace hard code of configuration continuation flag.
Date: Wed, 29 Sep 2010 14:36:15 +0300 [thread overview]
Message-ID: <20100929113615.GH1931@null> (raw)
In-Reply-To: <AANLkTi=EVEwuKy3QwNJ1sVpe2_EJCkQQ3iGutKQQRneU@mail.gmail.com>
Hi,
Patch is ok but just one comment. See below.
On Wed, Sep 29, 2010 at 01:12:39PM +0200, haijun liu wrote:
>
> Replace hard code of configuration continuation flag with self-comment macro.
>
> - if (flags & 0x0001) {
> + if (flags & L2CAP_CONF_FLAG_CONT) {
> /* Incomplete config. Send empty response. */
> l2cap_send_cmd(conn, cmd->ident, L2CAP_CONF_RSP,
> l2cap_build_conf_rsp(sk, rsp,
Maybe you could use L2CAP_CONF_FLAG_CONT also in l2cap_build_conf_rsp()?
--
Ville
next prev parent reply other threads:[~2010-09-29 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 9:21 [PATCH] Bluetooth: Replace hard code of configuration continuation flag haijun liu
2010-09-28 23:48 ` Gustavo F. Padovan
2010-09-29 11:12 ` haijun liu
2010-09-29 11:36 ` Ville Tervo [this message]
2010-09-29 12:42 ` haijun liu
2010-09-29 13:12 ` Ville Tervo
2010-09-29 13:33 ` haijun liu
2010-09-30 7:24 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929113615.GH1931@null \
--to=ville.tervo@nokia.com \
--cc=dantian.ip@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=liuhaijun.er@gmail.com \
--cc=mathewm@codeaurora.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).