From: Johan Hedberg <johan.hedberg@nokia.com>
To: Ville Tervo <ville.tervo@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Add master/slave parsing for le_conn_complete event
Date: Thu, 30 Sep 2010 10:31:03 +0300 [thread overview]
Message-ID: <20100930073103.GA6687@jh-x301> (raw)
In-Reply-To: <1285768581-19654-1-git-send-email-ville.tervo@nokia.com>
Hi Ville,
On Wed, Sep 29, 2010, Ville Tervo wrote:
> ---
> parser/hci.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Thanks for the patch. I've pushed it to the upstream hcidump tree with
the following whitespace fix:
> + evt->status, btohs(evt->handle), evt->role?"slave":"master");
It should be 'evt->role ? "slave" : "master"' i.e. you've got some
missing spaces there.
Johan
prev parent reply other threads:[~2010-09-30 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 13:56 [PATCH 1/2] Add master/slave parsing for le_conn_complete event Ville Tervo
2010-09-29 13:56 ` [PATCH 2/2] Fix missing comma in cmd_le_str Ville Tervo
2010-09-30 7:31 ` Johan Hedberg
2010-09-30 7:31 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930073103.GA6687@jh-x301 \
--to=johan.hedberg@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).